After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518103 - evolution does not check online status at startup
evolution does not check online status at startup
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.22.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 525616 526544 snafu (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-22 17:41 UTC by JP Rosevear
Modified: 2008-04-26 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (5.58 KB, patch)
2008-03-14 16:10 UTC, Matthew Barnes 		reviewed Details | Review
Proposed patch that keeps --offline working (2.07 KB, patch)
2008-04-17 14:48 UTC, James Westby 		committed Details | Review

Description JP Rosevear 2008-02-22 17:41:10 UTC 
evolution does not check online status from networkmanager at startup, it seems to remember the last state use and start there first.
Comment 1 Matthew Barnes 2008-03-03 12:15:13 UTC 
Confirming, I've seen this myself.
Comment 2 Matthew Barnes 2008-03-11 00:35:12 UTC 
Bumping version to a stable release.
Comment 3 Matthew Barnes 2008-03-14 16:05:54 UTC 
EShell defines these offline states:

   E_SHELL_LINE_STATUS_OFFLINE
   E_SHELL_LINE_STATUS_FORCED_OFFLINE

I'm not sure why we still need this distinction; EShell itself treats both states equally as far as I can tell.

Anyway, when NetworkManager signals a device is now active, Evolution's NM listener is only checking for STATUS_OFFLINE.  But if I manually disable networking, Evolution puts itself in STATUS_FORCED_OFFLINE.  Thus, when I
enable networking again, Evolution's NM listener ignores the signal.
Comment 4 Matthew Barnes 2008-03-14 16:10:12 UTC 
Created attachment 107302 [details] [review]
Proposed patch

Fixes the issue and cleans up the code a bit in both e-shell-nm.c and e-shell-nm-glib.c.

As an aside, libnm-glib is deprecated.  Perhaps we should just drop e-shell-nm-glib.c?
Comment 5 Srinivasa Ragavan 2008-03-27 08:25:57 UTC 
Matt, I think I introduced this regression, while I fixed the issue of "unable to start evolution in offline with evolution --offline. It start in online". But with your patch, again it fails to start in offline. I think we need to take care of both.
Comment 6 Matthew Barnes 2008-03-27 15:04:57 UTC 
Okay, I'll have a look at what you changed and then take another shot at this.
Comment 7 Matthew Barnes 2008-04-01 23:57:23 UTC 
*** Bug 525616 has been marked as a duplicate of this bug. ***
Comment 8 Matthew Barnes 2008-04-06 18:24:16 UTC 
*** Bug 526544 has been marked as a duplicate of this bug. ***
Comment 9 James Westby 2008-04-17 14:48:08 UTC 
Created attachment 109428 [details] [review]
Proposed patch that keeps --offline working

Hi,

Here is a patch that keeps --offline working in my tests.

I'd be happy to work to improve improve it if anyone has any
comments.

Thanks,

James
Comment 10 Srinivasa Ragavan 2008-04-18 03:43:38 UTC 
James, your patch works well in all scenarios I tested. I will review it today and try to take it for the next release.
Comment 11 Srinivasa Ragavan 2008-04-21 08:56:54 UTC 
Commit to stable/head.
Comment 12 André Klapper 2008-04-23 08:28:37 UTC 
*** Bug 529201 has been marked as a duplicate of this bug. ***
Comment 13 Suman Manjunath 2008-04-26 14:49:00 UTC 
Patch committed to stable branch (gnome-2-22) as r35419
http://svn.gnome.org/viewvc/evolution?view=revision&revision=35419

Patch committed to SVN trunk as r35420
http://svn.gnome.org/viewvc/evolution?view=revision&revision=35420