After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512600 - Don't use gnome_vfs_uri_list_parse
Don't use gnome_vfs_uri_list_parse
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 512602
 
 
Reported: 2008-01-28 16:06 UTC by Bastien Nocera
Modified: 2008-02-17 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix bug (8.54 KB, patch)
2008-02-16 19:11 UTC, Jon Dufresne 		rejected Details | Review

Description Bastien Nocera 2008-01-28 16:06:37 UTC 
We should use g_uri_list_extract_uris() instead in totem_action_drop_files() instead, in both totem.c and drop_cb.
Comment 1 Jon Dufresne 2008-02-16 17:09:31 UTC 
I will write a patch. I found this bug through gnome-love. I looked through the code and this looks very straight forward.

As far as testing goes, what do I need to do in totem to get it to execute this section of code?
Comment 2 Bastien Nocera 2008-02-16 17:28:49 UTC 
it's used in a couple of places, but only when parsing drag'n'drops output. Just check that no files are missing, and that drag'n'drops from Mozilla/Firefox work as expected.
Comment 3 Jon Dufresne 2008-02-16 19:11:11 UTC 
Created attachment 105404 [details] [review]
patch to fix bug

This patch does as the bug suggests. Very simple, and testing shows that it works.
Comment 4 Bastien Nocera 2008-02-17 01:02:19 UTC 
The patch is unusable, it seems to have loads of white space changes that bear no relevance to the patch whatsoever.
Comment 5 Philip Withnall 2008-02-17 01:07:42 UTC 
...and there's already a fix for this bug in my patch for bug #512602, which I probably should've mentioned here when I put it up on Bugzilla (sorry about that).
Comment 6 Philip Withnall 2008-02-17 11:15:34 UTC 
2008-02-17  Philip Withnall  <pwithnall@svn.gnome.org>

	* src/totem-playlist.c: (drop_cb):
	* src/totem.c: (totem_action_drop_files): Use
	g_uri_list_extract_uris instead of gnome_vfs_uri_list_parse
	for drop targets. (Closes: #512600)