After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510406 - Rhythmbox uses wrong DBus interface for media keys
Rhythmbox uses wrong DBus interface for media keys
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 505907 514750 515329 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-18 14:33 UTC by Rodrigo Moya
Modified: 2008-02-12 22:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to use the correct Dbus interface names (1.81 KB, patch)
2008-01-18 14:36 UTC, Rodrigo Moya 		none Details | Review
rb-mmkeys-new-api.patch (1.89 KB, patch)
2008-02-07 00:30 UTC, Bastien Nocera 		committed Details | Review

Description Rodrigo Moya 2008-01-18 14:33:00 UTC 
With the move of the gnome-settings-daemon to its own module, the DBus interface names have changed.

Attached patch makes rhythmbox use the correct one for the media keys plugin
Comment 1 Rodrigo Moya 2008-01-18 14:36:03 UTC 
Created attachment 103144 [details] [review]
Patch to use the correct Dbus interface names
Comment 2 Jonathan Matthew 2008-01-19 00:45:56 UTC 
We need to maintain compatibility with older gnome-settings-daemons for a while, so we can't just change the interface name like this.
Comment 3 Bastien Nocera 2008-02-04 18:11:50 UTC 
It should use dbus_g_proxy_new_for_name_owner() so that the instantiation of the proxy can fail nicely.
Comment 4 Bastien Nocera 2008-02-06 13:29:20 UTC 
*** Bug 514750 has been marked as a duplicate of this bug. ***
Comment 5 Sebastien Bacher 2008-02-06 20:37:51 UTC 
the bus name should still be org.gnome.SettingsDaemon, the change is not correct
Comment 6 Bastien Nocera 2008-02-07 00:30:59 UTC 
Created attachment 104609 [details] [review]
rb-mmkeys-new-api.patch

Updated patch with compat API. Untested.
Comment 7 Bastien Nocera 2008-02-09 01:53:08 UTC 
*** Bug 515329 has been marked as a duplicate of this bug. ***
Comment 8 Jonh Wendell 2008-02-09 09:06:10 UTC 
Ubuntu is using this patch and it is working fine to me.
Comment 9 Jonathan Matthew 2008-02-09 23:46:37 UTC 
The fallback didn't actually work in that patch.  It's the GrabMediaPlayerKeys call that fails.  I've fixed that, tested it a bit, and committed it.
Comment 10 Götz Waschk 2008-02-12 22:13:21 UTC 
*** Bug 505907 has been marked as a duplicate of this bug. ***