GNOME Bugzilla – Bug 505990
Make distcheck fails on extension install not in --prefix
Last modified: 2008-09-07 15:33:39 UTC
nautilus 2.21 looks for extensions in /usr/lib/nautilus/extensions-2.0
Possible way to fix: http://svn.gnome.org/viewvc/nautilus-open-terminal?view=revision&revision=156 (note: the .pc file is not correct yet, should be in 2.21.2)
Created attachment 101956 [details] [review] Patch to fetch nautilus extension dir
Committed. Thanks. 2008-01-07 Adam Schreiber <sadam@clemson.edu> * plugins/nautilus-ext/Makefile.am (nautilus_extensiondir): * configure.in (NAUTILUS_LIBS): Fetch nautilus extension dir from libnautilus-extension.pc. Patch from Brian Pepple. Fixes bug #505990
This does not pass make distcheck, and is preventing a 2.21.5 release. I tried to fix it by adding a $(DESTDIR) variable, but that does not work. I'm no wizard in the voodoo that is autotools.
I can't replicate the problem here. make distcheck succeeds as root. ================================================= seahorse-2.21.5 archives ready for distribution: seahorse-2.21.5.tar.gz ================================================= As far as I can tell with svn diff, there are no modified files in my local directory structure.
I was able to have distcheck succeed also as root, on a fresh co. ================================================= seahorse-2.21.5 archives ready for distribution: seahorse-2.21.5.tar.gz =================================================
The reason it succeeds as root is because it scribbles all over /usr/lib during a distcheck, and the same will occur for those building packages. make distcheck shouldn't be run as root.
distcheck uses --prefix, not DESTDIR, so adding a DESTDIR does not help. One approach would be to add --disable-nautilus-extension (or some other flag that just disables installing it) to DISTCHECK_CONFIGURE_FLAGS
Hmmm, that is a solution, but I'd certainly rather build the nautilus extension during distcheck. Does anyone know if there's a shell variable we can use in configure.in to detect whether the script is in distcheck mode or not? That way we can force a path within the prefix for the nautilus extension while doing a distcheck.
There is no such shell variable, but you can add one yourself, set by e.g. --disable-nautilus-extension-install which you pass in from DISTCHECK_CONFIGURE_FLAGS.
Installation of our epiphany plugin has this same issue.
any news here? this is blocking a release.
Adam, how do we build the epiphany plugin? I'm on ubuntu and can't figure out what packages to install to get it to build. There's thousands of lines of autofoo being run, and it's all very confusing for me.
The easiest way to get the build dependencies on Ubuntu is to run sudo apt-get build-dep seahorse (remember that hardy doesn't reflect the package split) and sudo apt-get build dep epiphany-extensions
Hmmm, still doesn't work for me. Moving this build discussion to the mailing list, as it's not totally on topic for this bug report. Hope that's okay.
This works now.