GNOME Bugzilla – Bug 494049
painting doesn't update the histogram
Last modified: 2008-10-30 20:03:57 UTC
Due to the changes made to fix bug #490182, the histogram is not any longer updated when paint tools are used on the image. This is because the histogram now listens for drawable updates and not any longer for the preview becoming invalid.
Created attachment 98641 [details] [review] changed paint core to update the drawable This patch changes the paint core to update the drawable instead of the image. In order to suppress an update of the drawable preview, the new freeze/thaw functionality is used. This makes the code cleaner and it fixes the problem. However, it causes the histogram to be updated while the user paints. This happens from an idle handler, but it might still be updating too often. Perhaps we should use a short timeout instead?
Created attachment 98642 [details] [review] also change the histogram to use a timeout This patch seems to work nicely. Additionally to the paint-core changes, it changes the histogram to use a short timeout instead of an idle handler.
I have applied the change to both branches: 2007-11-13 Sven Neumann <sven@gimp.org> Fix for bug #494049 (painting doesn't update the histogram): * app/paint/gimppaintcore.c: freeze the drawable preview while we are painting. Update the drawable instead of the image. * app/widgets/gimphistogrameditor.c: use a short timeout instead of an idle handler to update the histogram.