GNOME Bugzilla – Bug 486909
Where Am I should say "n of m items selected" and "on item x of y" in layered pane
Last modified: 2008-02-12 19:01:16 UTC
Steps to reproduce: 1) Run the Icon View -> Icon View Basics demo of gtk-demo 2) Arrow down to the first icon. Press Shift+Right to select two icons. 3) Press KP_Enter to get Where Am I information. Orca should present how many items are selected. In addition, when doing a Where Am I, the position information of the focused item (e.g., "item x of y items") should be presented.
I'm not sure what is needed from me here. We should do the same thing we do for tree tables.
Mike - where among all the other things in the where am I information should the selection state be presented and where should the item count be presented?
As I don't think this is some of the most important information we are presenting with WhereAmI lets just stick it on the very end of the speech string. If anyone disagrees please chime in as I don't feel really strongly about this one.
I don't feel strongly about this one either, but I would like a spec please. <smile> Modifying Will's original example and providing a bit more detail: 1. You have 24 icons total 2. Four of the icons are selected: lib64, lost+found, sbin, srv 3. These four icons occupy the 2x2 space defined by row 2, column 3 through row 3, column 4. 4. lost+found is the selected icon (row 2, column 4) Here's what we currently say: "Icon panel, lost+found, icon, 0 of 24 items selected" Here are my questions: 1. If we're in an icon panel on an item, there's an excellent chance we're sitting on an icon. Therefore, is saying "icon" redundant? 2. Clearly it should be "4 of 24" selected. But what is the "item x of y" bit? Are we on item 2 of 4, or 11 of 24? 3. Do we care at all about the spatial arrangement of the selection? (We probably don't, but I figured I'd ask.) Whatever you want should be easy enough to whip out. I just need to know what that is. Thanks!
> > Here are my questions: > > 1. If we're in an icon panel on an item, there's an excellent chance > we're sitting on an icon. Therefore, is saying "icon" redundant? Yes it is OK to remove the speaking of icon. > 2. Clearly it should be "4 of 24" selected. But what is the "item x > of y" bit? Are we on item 2 of 4, or 11 of 24? 11 of 24 > 3. Do we care at all about the spatial arrangement of the selection? No I don't think so.
> > 2. Clearly it should be "4 of 24" selected. But what is the "item x > > of y" bit? Are we on item 2 of 4, or 11 of 24? > 11 of 24 So we should say "4 of 24 selected, on item 11 of 24"? Or should we say "4 of 24 selected on item 11?" Or something else?
As an aside, we are already saying "4 of 24" selected in Nautilus. We do that by looking to see how many children have STATE_SELECTED. When examining the icons in the gtk-demo used by Will, they all have STATE_SELECTABLE, but selected icons don't seem to expose STATE_SELECTED. I'll look again tomorrow to see if there's something else we can to do obtain the same information. However, that bit is looking like a gtk bug.
I personally like > "4 of 24 selected, on item 11 of 24"
Sounds good. I'll work on implementing that and test with Nautilus. I just opened bug #501117 because GtkIconView is not exposing STATE_SELECTED for selected items. Until it does, saying "n of m items selected" *correctly* won't be possible.
Created attachment 100067 [details] [review] proposed patch This does what Mike specified. Mike please test (using Nautilus rather than gtk-demo). Will please review. Thanks!
Looks awesome. Thanks!
Thanks. Committed. In retrospect, what I should have done is created a new Orca tracking bug for the gtk issue and made that a depends on the gtk issue. But I didn't and I don't want to spam the gtk guys. So.... Changing the status of this one to just "blocked" and removing the target milestone. Theoretically, once they fix their bug Orca will just do the right thing.
The last remaining issue (in gtk-demo, correctly stating the number of selected items), was fixed by bug 499835. Therefore closing this one as FIXED.