GNOME Bugzilla – Bug 482017
autoconf fails unless g-d-u is already installed
Last modified: 2020-03-03 18:34:52 UTC
On my OS X 10.3 machine with autoconf-2.60 and automake-1.9.5, I can only "autoreconf -f -i" gnome-doc-utils-0.12.0 if I already have a gnome-doc-utils package installed. If not: autoreconf -f -i tools/gnome-doc-utils.make:63: HAVE_GNOME_DOC_UTILS does not appear in AM_CONDITIONAL doc/gnome-doc-make/Makefile.am:1: `tools/gnome-doc-utils.make' included from here tools/gnome-doc-utils.make:133: ENABLE_SK does not appear in AM_CONDITIONAL doc/gnome-doc-make/Makefile.am:1: `tools/gnome-doc-utils.make' included from here tools/gnome-doc-utils.make:182: ENABLE_SK does not appear in AM_CONDITIONAL doc/gnome-doc-make/Makefile.am:1: `tools/gnome-doc-utils.make' included from here tools/gnome-doc-utils.make:63: HAVE_GNOME_DOC_UTILS does not appear in AM_CONDITIONAL doc/xslt/Makefile.am:1: `tools/gnome-doc-utils.make' included from here tools/gnome-doc-utils.make:133: ENABLE_SK does not appear in AM_CONDITIONAL doc/xslt/Makefile.am:1: `tools/gnome-doc-utils.make' included from here tools/gnome-doc-utils.make:182: ENABLE_SK does not appear in AM_CONDITIONAL doc/xslt/Makefile.am:1: `tools/gnome-doc-utils.make' included from here autoreconf: automake failed with exit status: 1 ### execution of autoreconf failed, exit code 1 The primary error is that HAVE_GNOME_DOC_UTILS is defined in a support file in tools/ that gets installed when g-d-u is installed, but tools/ itself is not searched by autotools. A fix is to pass "-I tools" in ACLOCAL. Fixing this also clears the ENABLE_SK error and allows g-d-u to build successfully.
Created attachment 96437 [details] [review] Pass "-I tools" in ACLOCAL
why not add AC_CONFIG_MACRO_DIR([tools]) to configure.ac instead? i often find myself skipping whichever project's native autogen.sh for simply utilizing gnome-autogen.sh which most autogens pass everything on to
I saw there already was an ACLOCAL_AMFLAGS passed in Makefile.am, so adding more seemed cleanest (more confusing if "the same kind of action" is performed multiple ways and spread across multiple files). I don't know if AC_CONFIG_MACRO_DIR can accept multiple paths (I don't think so?). That macro is new (in the realm of autotools) but also provides more features (with regards to libtoolize and related things) than the AMFLAGS approach.Maybe the best solution would be to put *all* .m4 in the tools/ subdir (or even more standardly, name it m4/) and then a single AC_CONFIG_MACRO_DIR that one unified location.
The files in the tools subdir are meant to be re-used by other packages using gnome-doc-utils. Therefor I think it is not a good idea to move gnome-doc-utils.m4 from there to the m4 subdir. Because gnome-doc-utils is actually using gnome-doc-utils.m4 by bootstrapping, quite comparable to how any other package that is using gnome-doc-utils uses it, I think the solution to add "-I tools" to ACLOCL_AMFLAGS is the right solution here.
Created attachment 205358 [details] [review] 0001-Add-I-tools-to-ACLOCAL_AMFLAGS.patch Updated patch from comment 1 to current master.
*** Bug 641446 has been marked as a duplicate of this bug. ***
This was fixed by https://git.gnome.org/browse/gnome-doc-utils/commit/?id=67d8ef459e7a7e4b21b53d02704f77292cf017e0 from bug #755966 and can be closed
gnome-doc-utils has been superseded by yelp-xsl, yelp-tools, and itstool. gnome-doc-utils will not see any further development, hence closing as WONTFIX. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/255