After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 481585 - Accessible gnome-about rewrite
Accessible gnome-about rewrite
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: gnome-about
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-29 13:01 UTC by guillaume
Modified: 2007-11-12 22:11 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Proposed gnome-about.py (29.83 KB, text/x-python)
2007-09-29 13:03 UTC, guillaume
  Details
Updated + integration with gnome-desktop module (74.92 KB, patch)
2007-10-28 22:06 UTC, Vincent Untz
none Details | Review
Updated diff (supports --gnome-version) against gnome-desktop (39.72 KB, patch)
2007-10-31 13:11 UTC, guillaume
none Details | Review

Description guillaume 2007-09-29 13:01:32 UTC
In regards of the currently opened bugs against gnome-about, I rewrote it to make it cleaner and more accessible. Instead of using a Canvas (namely GnomeCanvas), this rewrite is just using a GtkLayout and real GtkLabel's and such. The animation is now using a GtkAlignment and a GtkLayout to produce a simple, but clean movement (suggestions welcome for different).
Comment 1 guillaume 2007-09-29 13:03:07 UTC
Created attachment 96369 [details]
Proposed gnome-about.py
Comment 2 Benjamin Gramlich 2007-10-11 15:47:58 UTC
I think this is fantastic. 
Comment 3 Vincent Untz 2007-10-28 16:20:00 UTC
FWIW, fixes: bug 104753, bug 125295, bug 125299, bug 125313, bug 353009, bug 91700.

Should fix bug 125296, bug 125310 too (didn' test).

Need work for bug 125311 to be fixed (menu key and shift+F10 should open the popup menu on links, eg).

Also, pressing enter when a link is selected (with tab) closes the dialog and opens the link. It shouldn't close the dialog.
Comment 4 Vincent Untz 2007-10-28 16:23:39 UTC
Also, maybe it'd be a good idea to have a header similar to the one on our website: http://www.gnome.org/. Don't know. Just an idea.
Comment 5 Vincent Untz 2007-10-28 17:36:08 UTC
Guillaume sent me a new version, with fixes. A few other bugs before I forget:

 + if you click at the right or left of the name of a contributor, the animation is done. However, if you do the same for the description, nothing happens: you have to click on the text.

 + if you select the description or the contributor name (with tab), and wait for the animation, the selection is lost. I think it'd be better to keep it with the new text. Or maybe to not animate?

 + if you tab on the dialog until the close button, when the selection hits the close button, the last line of text is still selected.

 + the rewind is happening too fast. Two ways to fix this: either add a new empty string after the last line of description, or not animate the last line of description and directly do the rewind.
Comment 6 Vincent Untz 2007-10-28 17:43:08 UTC
Other bugs:

 + with menu/shift+F10, the menu should probably appear below the hyperlink, not in the middle of it (so the text is still visible)

 + in C, we generally do:
   if ((event->state & gtk_accelerator_get_default_mod_mask ()) == GDK_SHIFT_MASK)
   I guess the same function is available for python.
Comment 7 Vincent Untz 2007-10-28 22:06:47 UTC
Created attachment 98050 [details] [review]
Updated + integration with gnome-desktop module
Comment 8 guillaume 2007-10-31 13:11:01 UTC
Created attachment 98240 [details] [review]
Updated diff (supports --gnome-version) against gnome-desktop
Comment 9 Vincent Untz 2007-11-12 22:11:03 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.