After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464446 - Zoom to Fit feature vanished from UI
Zoom to Fit feature vanished from UI
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.10.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 472893 494695 520104 522878 531179 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-08-07 18:14 UTC by Ben
Modified: 2008-05-03 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make "Zoom to Fit" pref and keybinding work again (2.17 KB, patch)
2007-08-07 18:15 UTC, Ben
none Details | Review

Description Ben 2007-08-07 18:14:08 UTC
Please describe the problem:
In recent gthumb versions I have not found a way to make images zoom to fit in all cases. I use this to make sure images will be truly fullscreen in slideshows regardless of whether they are smaller, taller, or wider than the screen.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ben 2007-08-07 18:15:01 UTC
Created attachment 93231 [details] [review]
Make "Zoom to Fit" pref and keybinding work again
Comment 2 Michael Chudobiak 2007-08-08 11:38:20 UTC
The fit-if-larger mode is the default (specified in preferences), so I think that the "x" key should be saved for that.

However, we could bind another free key (are any left?) to the fit-always mode.

- Mike


Comment 3 Paolo Bacchilega 2007-08-11 09:55:31 UTC
I added shift+x keybinding to always perform a zoom to fit, it'll be available in version 2.10.6 and greater, thanks.
Comment 4 Dave Jenkins 2007-11-26 23:10:23 UTC
Thanks for the patch, Ben. gthumb-2.10.7-1.fc8 (Fedora) still has this problem and your patch applied cleanly to this and resolved it. I just used the 2nd & 3rd chunks, for the "Fit to window" preference; I wasn't bothered about the key binding. I vote for this bug to be re-opened and the "Fit to window" preference to be restored, if this has not already been done. AFAICS Paolo's comments address the key binding issue but not the preference issue, apologies if I have misunderstood.

Thanks, Dave.
Comment 5 Michael Chudobiak 2007-11-30 20:34:43 UTC
*** Bug 472893 has been marked as a duplicate of this bug. ***
Comment 6 Michael Chudobiak 2007-11-30 20:35:16 UTC
*** Bug 494695 has been marked as a duplicate of this bug. ***
Comment 7 Michael Chudobiak 2008-03-17 17:52:02 UTC
*** Bug 522878 has been marked as a duplicate of this bug. ***
Comment 8 Michael Chudobiak 2008-04-08 12:48:46 UTC
The Fit-To-Window mode has been added to the preferences dialog. The x/shift-x keybindings are unchanged.

Closing as "fixed". This will appear in 2.11.0.

http://svn.gnome.org/viewvc/gthumb?rev=2317&view=rev

- Mike
Comment 9 Michael Chudobiak 2008-04-08 12:56:18 UTC
*** Bug 520104 has been marked as a duplicate of this bug. ***
Comment 10 Michael Chudobiak 2008-05-03 12:45:56 UTC
*** Bug 531179 has been marked as a duplicate of this bug. ***