Created attachment 91515 [details] [review]
Patch implementing the focus behavior for Ctrl+L

Permission to apply patch?

Would be great to have this in before the next stable release...

Sorry for the huge delay in reviewing this.  The patch is very nice; thanks, Jaap!  I just made some changes to make the surrounding code a bit cleaner.  Will attach updated version.

Created attachment 96522 [details] [review]
gtk2-bgo-455284-file-chooser-ctrl-l-focus.diff

This is the patch I committed.  Thanks for working on this, Jaap :)

2007-10-02  Federico Mena Quintero  <federico@novell.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=455284 - In the file
	chooser, Ctrl-L should switch to the location entry.  If we are
	already on the location entry, turn it off.  Based on a patch by
	Jaap A. Haitsma <jaap@haitsma.org> and an idea by Wouter
	Bolsterlee.

	* gtk/gtkfilechooserdefault.c (location_button_toggled_cb): Call
	location_mode_set() directly instead of using toggle_location_mode().
	(toggle_location_mode): Removed.
	(location_toggle_popup_handler): If the file entry is not visible,
	show it.  If it is visible, turn it off only if it is focused.
	Otherwise, switch to the entry.

Thanks, both of you. I really like to see this fixed.

Any plans to backport this to the stable series? (please do!)

It was committed to trunk, which is still for 2.12 (stable) :)