After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 455284 - Ctrl+L should work depending if it has focus or not
Ctrl+L should work depending if it has focus or not
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.11.x
Other Linux
: Normal enhancement
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2007-07-09 20:28 UTC by Jaap A. Haitsma
Modified: 2007-10-02 23:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the focus behavior for Ctrl+L (853 bytes, patch)
2007-07-09 21:00 UTC, Jaap A. Haitsma 		none Details | Review
gtk2-bgo-455284-file-chooser-ctrl-l-focus.diff (2.78 KB, patch)
2007-10-02 15:52 UTC, Federico Mena Quintero 		committed Details | Review

Description Jaap A. Haitsma 2007-07-09 20:28:50 UTC 
See suggestion Wouter Bolsterlee http://bugzilla.gnome.org/show_bug.cgi?id=383354#c10
Comment 1 Jaap A. Haitsma 2007-07-09 21:00:53 UTC 
Created attachment 91515 [details] [review]
Patch implementing the focus behavior for Ctrl+L
Comment 2 Jaap A. Haitsma 2007-07-19 05:19:43 UTC 
Permission to apply patch?
Comment 3 Wouter Bolsterlee (uws) 2007-07-19 09:53:28 UTC 
Would be great to have this in before the next stable release...
Comment 4 Federico Mena Quintero 2007-10-02 15:32:12 UTC 
Sorry for the huge delay in reviewing this.  The patch is very nice; thanks, Jaap!  I just made some changes to make the surrounding code a bit cleaner.  Will attach updated version.
Comment 5 Federico Mena Quintero 2007-10-02 15:52:17 UTC 
Created attachment 96522 [details] [review]
gtk2-bgo-455284-file-chooser-ctrl-l-focus.diff

This is the patch I committed.  Thanks for working on this, Jaap :)

2007-10-02  Federico Mena Quintero  <federico@novell.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=455284 - In the file
	chooser, Ctrl-L should switch to the location entry.  If we are
	already on the location entry, turn it off.  Based on a patch by
	Jaap A. Haitsma <jaap@haitsma.org> and an idea by Wouter
	Bolsterlee.

	* gtk/gtkfilechooserdefault.c (location_button_toggled_cb): Call
	location_mode_set() directly instead of using toggle_location_mode().
	(toggle_location_mode): Removed.
	(location_toggle_popup_handler): If the file entry is not visible,
	show it.  If it is visible, turn it off only if it is focused.
	Otherwise, switch to the entry.
Comment 6 Wouter Bolsterlee (uws) 2007-10-02 16:08:20 UTC 
Thanks, both of you. I really like to see this fixed.
Comment 7 Wouter Bolsterlee (uws) 2007-10-02 16:08:48 UTC 
Any plans to backport this to the stable series? (please do!)
Comment 8 Federico Mena Quintero 2007-10-02 23:45:42 UTC 
It was committed to trunk, which is still for 2.12 (stable) :)