After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 437989 - Inconsistent behaviour for adding a bookmark
Inconsistent behaviour for adding a bookmark
Status: RESOLVED DUPLICATE of bug 561221
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2007-05-12 21:51 UTC by Emmanuele Bassi (:ebassi)
Modified: 2013-05-21 07:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emmanuele Bassi (:ebassi) 2007-05-12 21:51:02 UTC
right now, in order to add a bookmark to the shortcuts pane of the GtkFileChooser default implementation you can select a path in the files pane and click on the 'Add' button or you can drag and drop the row from one pane to the other.

the inconsistency is in the validation of the paths: the 'Add' button becomes insensitive when selecting a file and returns sensitive when selecting a folder, suggesting that only folders can be bookmarks; if I drop a file on the shortcut pane, though, the bookmark is accepted.

also, now that the file chooser has three modes of operation (browse, search and recent files), we must keep consistency in all those cases. accepting only folders require validation inside the shortcuts pane drop function, because we might want to drag a file from the file chooser to another drop target. accepting all kind of paths would make the sensitivity checks go away.
Comment 1 Federico Mena Quintero 2007-05-14 18:39:59 UTC
I think we should do this:

1. Remove the Add and Remove buttons.

2. As the last row in the shortcuts pane, add an unclickable row with "Drag bookmark here" in italics.

3. Have a "Bookmark <selected filename>" command in the contextual menu in the file list --- we have that right now, but it doesn't show you the filename.

4. Have a "Bookmark <current folder name>" command in the contextual menu for the shortcuts pane.

5. Allow bookmarking files and folders (i.e. do no checking at all).
Comment 2 Timothy Arceri 2013-05-21 07:30:15 UTC
Marking as duplicate as the latest thinking seems to be that there should be a check to stop files from being bookmarked.

*** This bug has been marked as a duplicate of bug 561221 ***