After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435406 - [Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook
[Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook
Status: RESOLVED FIXED
Product: gnome-volume-manager
Classification: Deprecated
Component: general
2.17.x
Other All
: Normal normal
: ---
Assigned To: Gnome volume manager maintainers
Gnome volume manager maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-03 05:26 UTC by David Farning
Modified: 2007-10-13 17:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch to run gtk-update-icon-cache install-hook and uninstall-hook (2.04 KB, patch)
2007-05-03 05:33 UTC, David Farning 		none Details | Review

Description David Farning 2007-05-03 05:26:03 UTC 
Please describe the problem:
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook. Refer to #362604.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 David Farning 2007-05-03 05:33:40 UTC 
Created attachment 87430 [details] [review]
patch to run gtk-update-icon-cache install-hook and uninstall-hook
Comment 2 Jeffrey Stedfast 2007-05-03 15:43:43 UTC 
is it really kosher to be installing custom icons to the gnome icon theme dir?
Comment 3 Luca Ferretti 2007-06-27 20:12:43 UTC 
The real issue here is that gnome-volume-manager should install a custom icon for properties dialog.

This icon should be placed in "hicolor" icon theme (that's why you need to update icon cache on install and uninstall) and should be named as the related executable in $porefix/bin (i.e. "gnome-volume-properties"). I'll ask on theme list.

Oh, the reason. We can't ship all needed icons in gnome-icon-theme, we like to put in it only icons from Icon Naming Spec, so application should install their own application icon and "stock" icons in the best way.
Comment 4 Luca Ferretti 2007-06-27 20:14:39 UTC 
PS you non longer need to provide gvm-dev-tablet.png icon. "input-tablet" is currently available in gnome-icon-theme (see my patch on bug 413925).
Comment 5 Jeffrey Stedfast 2007-10-13 17:22:03 UTC 
this is no longer needed