Bug 428560 – GameGenerator.increment_label() not i18n safe

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 428560 - GameGenerator.increment_label() not i18n safe


Summary:	GameGenerator.increment_label() not i18n safe


Status:	RESOLVED FIXED

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	unspecified
Hardware:	Other All

Importance:	High blocker
Target Milestone:	---
Assigned To:	Andreas Røsdal
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Duplicates:	429477 431367 433179 434281 435927 435992 438478 447550 448026 451349 460094 461426 464951 465043 467879 470050 473240 473907 476987 479178 481875 483605 484003 486324 486460 493323 493565 515632 (view as bug list)
Depends on:
Blocks:

Reported:	2007-04-11 09:43 UTC by ed
Modified:	2008-02-11 07:09 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
Proposed patch (717 bytes, patch) 2007-05-01 13:08 UTC, Andreas Røsdal	committed	Details \| Review

Description ed 2007-04-11 09:43:40 UTC

What were you doing when the application crashed?
create new puzzle


Distribution: Ubuntu 7.04 (feisty)
Gnome Release: 2.18.1 2007-04-11 (Ubuntu)
BugBuddy Version: 2.18.1

System: Linux 2.6.20-14-lowlatency #2 SMP PREEMPT Mon Apr 2 16:35:43 UTC 2007 x86_64
X Vendor: The X.Org Foundation
X Vendor Release: 70200000
Selinux: No
Accessibility: Disabled
GTK+ Theme: Human
Icon Theme: Human

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0



----------- .xsession-errors ---------------------
** (yelp:8560): WARNING **: IOR not set.
** (yelp:8560): WARNING **: Could not locate registry
Traceback (most recent call last):

+ Trace 126824

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gnome_sudoku.py", line 834 in generate_puzzle_gui
```
sudoku_generator_gui.GameGenerator(self,self.gconf)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 74 in __init__
```
self.setup_base_status()
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 149 in setup_base_status
```
self.increment_label(self.mediumLabel)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 160 in increment_label
```
curval = int(curtext.split()[0])
```

ValueError: invalid literal for int() with base 10: '1\xea\xb0\x9c'

--------------------------------------------------
Traceback (most recent call last):

+ Trace 126824

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gnome_sudoku.py", line 834 in generate_puzzle_gui
```
sudoku_generator_gui.GameGenerator(self,self.gconf)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 74 in __init__
```
self.setup_base_status()
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 149 in setup_base_status
```
self.increment_label(self.mediumLabel)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku_generator_gui.py", line 160 in increment_label
```
curval = int(curtext.split()[0])
```

ValueError: invalid literal for int() with base 10: '1\xea\xb0\x9c'

Comment 1 Andreas Røsdal 2007-04-13 19:26:53 UTC

*** Bug 429477 has been marked as a duplicate of this bug. ***

Comment 2 Robert Ancell 2007-04-15 02:33:29 UTC

increment_label() is not i18n safe.

It assumes labels are in the form:
"%d puzzles"

As it splits the string and converts the first value to an integer. The count needs to be stored somewhere and not extracted from the string.

Comment 3 Robert Ancell 2007-04-27 00:45:43 UTC

423660 and 427375 are duplicates.

Comment 4 Robert Ancell 2007-04-27 00:45:52 UTC

*** Bug 419388 has been marked as a duplicate of this bug. ***

Comment 5 Robert Ancell 2007-04-27 00:46:24 UTC

*** Bug 433179 has been marked as a duplicate of this bug. ***

Comment 6 Robert Ancell 2007-04-27 01:03:13 UTC

*** Bug 431367 has been marked as a duplicate of this bug. ***

Comment 7 Robert Ancell 2007-04-30 00:15:57 UTC

*** Bug 434281 has been marked as a duplicate of this bug. ***

Comment 8 Andreas Røsdal 2007-05-01 13:08:24 UTC

Created attachment 87330 [details] [review]
Proposed patch

Proposed patch.

Comment 9 Robert Ancell 2007-05-01 13:46:16 UTC

Clever! I didn't want to find the appropriate object to put the counter on - I didn't think of using the label object! Been coding in C for too many years...

Patch looks sane to me.

Comment 10 Andreas Røsdal 2007-05-10 15:04:44 UTC

*** Bug 435992 has been marked as a duplicate of this bug. ***

Comment 11 Thomas Andersen 2007-05-10 22:24:21 UTC

*** Bug 435927 has been marked as a duplicate of this bug. ***

Comment 12 Thomas Andersen 2007-05-15 09:25:45 UTC

*** Bug 438478 has been marked as a duplicate of this bug. ***

Comment 13 Thomas Andersen 2007-06-14 16:40:22 UTC

*** Bug 447550 has been marked as a duplicate of this bug. ***

Comment 14 Thomas Andersen 2007-06-15 23:06:44 UTC

*** Bug 448026 has been marked as a duplicate of this bug. ***

Comment 15 Thomas Andersen 2007-06-26 19:12:33 UTC

*** Bug 451349 has been marked as a duplicate of this bug. ***

Comment 16 Thomas Andersen 2007-07-25 23:32:03 UTC

*** Bug 460094 has been marked as a duplicate of this bug. ***

Comment 17 Damien Durand 2007-07-29 20:00:47 UTC

*** Bug 461426 has been marked as a duplicate of this bug. ***

Comment 18 Thomas Andersen 2007-08-17 01:26:27 UTC

*** Bug 464951 has been marked as a duplicate of this bug. ***

Comment 19 Thomas Andersen 2007-08-17 01:26:33 UTC

*** Bug 465043 has been marked as a duplicate of this bug. ***

Comment 20 Thomas Andersen 2007-08-18 12:25:08 UTC

*** Bug 467879 has been marked as a duplicate of this bug. ***

Comment 21 Gediminas Paulauskas 2007-08-27 10:18:58 UTC

*** Bug 470050 has been marked as a duplicate of this bug. ***

Comment 22 Thomas Andersen 2007-09-03 21:44:23 UTC

*** Bug 473240 has been marked as a duplicate of this bug. ***

Comment 23 palfrey 2007-09-05 15:31:50 UTC

*** Bug 473907 has been marked as a duplicate of this bug. ***

Comment 24 Andreas Røsdal 2007-09-15 21:07:52 UTC

*** Bug 476987 has been marked as a duplicate of this bug. ***

Comment 25 Thomas Andersen 2007-09-22 11:02:41 UTC

*** Bug 479178 has been marked as a duplicate of this bug. ***

Comment 26 Thomas Andersen 2007-09-30 23:16:28 UTC

*** Bug 481875 has been marked as a duplicate of this bug. ***

Comment 27 palfrey 2007-10-05 14:16:39 UTC

*** Bug 483605 has been marked as a duplicate of this bug. ***

Comment 28 Thomas Andersen 2007-10-07 22:08:42 UTC

*** Bug 484003 has been marked as a duplicate of this bug. ***

Comment 29 Christoph Wolk 2007-10-13 16:26:48 UTC

*** Bug 486324 has been marked as a duplicate of this bug. ***

Comment 30 Christoph Wolk 2007-10-14 02:11:25 UTC

*** Bug 486460 has been marked as a duplicate of this bug. ***

Comment 31 Christoph Wolk 2007-11-05 07:48:58 UTC

*** Bug 493323 has been marked as a duplicate of this bug. ***

Comment 32 Christoph Wolk 2007-11-05 07:49:03 UTC

*** Bug 493565 has been marked as a duplicate of this bug. ***

Comment 33 Thomas Andersen 2008-02-11 07:09:08 UTC

*** Bug 515632 has been marked as a duplicate of this bug. ***