GNOME Bugzilla – Bug 401530
[imap-features] imap-headers.glade issues
Last modified: 2009-08-05 18:08:29 UTC
if there is no custom header marked, disable the remove button. change the "custom header" window title to "add custom header". be descriptive. warning: this would be a string change. make the "add custom header" window modal. i can click on the account preferences window so the "add -> custom header" window will be in the background, and i can wonder for hours why nothing works at all, no matter how mad i click around. "Fetch A_ll Headers" - please avoid this mnemonic, as narrow letters should be generally avoided according to HIG: http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#choosing-access-keys warning: this would be a string change. also see bug 401523.
Created attachment 91738 [details] [review] Patch for imap-headers.glade and imap-header.c
"A" is already in use; modal issue is missing in the patch. (discussed on irc)
Bumping version to a stable release.
UI changed meanwhile. There is no Custom Headers window, it's a section now. Adding to its name "Add" is thus obsolete, as it would look strange. There is still "Fetch A_ll Headers" mnemonic. The Remove button is disabled by default, when there is no header defined, though as soon as you add at least one the button is enabled for ever, no matter whether is or isn't anything selected.
Created commit 91b219e in evo master (2.27.6+)