GNOME Bugzilla – Bug 398079
Wrong text colours used in ApplicationTile widget when hilighted
Last modified: 2020-03-05 10:54:48 UTC
The wrong text colour is used when ApplicationTiles are highlighted in libslab. See attached screenshot for an example.
Created attachment 80613 [details] Screenshot demonstrating the problem
Created attachment 82411 [details] [review] Patch to draw the buttons' text with selected state when selected Here's a patch to solve this problem. GtkButton does not deal with GTK_STATE_SELECTED natively, so we have to modify the fg color ourselves.
Committed to SVN already as well.
Reopening as this caused #407481 and I just reverted the patch.
Created attachment 88438 [details] [review] Alternative patch for bug #398079 This one doesn't bring 100% CPU for me.
Created attachment 88439 [details] [review] Alternative patch for bug #398079 This one doesn't bring 100% CPU for me.
Any comments on the patch?
CC'ing rodrigo.
Scott doesn't like the multiple '->parent... ' thing. Can't you change that to a more readable thing? Maybe concatenating several WHATEVER ( .. ) conversions.
Thanks for the patch but its kind of scary - widget->parent->parent->parent->parent->parent seems very brittle and readily broken by minor layout tweaks above in the widget hierarchy.
I guess that now we have GNOME 3, this is obsolete?
This project is not under active development anymore; see https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/263 Hence reflecting reality and mass-closing all its remaining open tasks.