Bug 398079 - Wrong text colours used in ApplicationTile widget when hilighted
Wrong text colours used in ApplicationTile widget when hilighted
Status: NEW
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME main menu maintainers
GNOME main menu maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-01-18 17:17 UTC by Thomas Wood
Modified: 2011-08-23 06:40 UTC (History)
4 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot demonstrating the problem (295.66 KB, image/png)
2007-01-18 17:18 UTC, Thomas Wood 		  Details
Patch to draw the buttons' text with selected state when selected (686 bytes, patch)
2007-02-12 19:07 UTC, Rodney Dawes 		rejected Details | Diff | Review
Alternative patch for bug #398079 (885 bytes, patch)
2007-05-19 12:44 UTC, Denis Washington 		none Details | Diff | Review
Alternative patch for bug #398079 (885 bytes, patch)
2007-05-19 12:46 UTC, Denis Washington 		needs-work Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Thomas Wood 2007-01-18 17:17:34 UTC 
The wrong text colour is used when ApplicationTiles are highlighted in libslab. See attached screenshot for an example.
Comment 1 Thomas Wood 2007-01-18 17:18:22 UTC 
Created attachment 80613 [details]
Screenshot demonstrating the problem
Comment 2 Rodney Dawes 2007-02-12 19:07:30 UTC 
Created attachment 82411 [details] [review]
Patch to draw the buttons' text with selected state when selected

Here's a patch to solve this problem. GtkButton does not deal with GTK_STATE_SELECTED natively, so we have to modify the fg color ourselves.
Comment 3 Rodney Dawes 2007-02-12 19:11:24 UTC 
Committed to SVN already as well.
Comment 4 Rodney Dawes 2007-02-14 17:57:41 UTC 
Reopening as this caused #407481 and I just reverted the patch.
Comment 5 Denis Washington 2007-05-19 12:44:19 UTC 
Created attachment 88438 [details] [review]
Alternative patch for bug #398079

This one doesn't bring 100% CPU for me.
Comment 6 Denis Washington 2007-05-19 12:46:03 UTC 
Created attachment 88439 [details] [review]
Alternative patch for bug #398079

This one doesn't bring 100% CPU for me.
Comment 7 Denis Washington 2007-06-14 17:43:25 UTC 
Any comments on the patch?
Comment 8 Denis Washington 2007-06-26 16:13:30 UTC 
CC'ing rodrigo.
Comment 9 Rodrigo Moya 2008-01-14 17:55:28 UTC 
Scott doesn't like the multiple '->parent... ' thing. Can't you change that to a more readable thing? Maybe concatenating several WHATEVER ( .. ) conversions.
Comment 10 Scott Reeves 2008-01-14 17:58:17 UTC 
Thanks for the patch but its kind of scary -
widget->parent->parent->parent->parent->parent  seems very brittle and readily
broken by minor layout tweaks above in the widget hierarchy.
Comment 11 Denis Washington 2011-08-23 06:40:24 UTC 
I guess that now we have GNOME 3, this is obsolete?
Note You need to log in before you can comment on or make changes to this bug.