After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351435 - libmuine abuses gnome-vfs API
libmuine abuses gnome-vfs API
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Christian Neumair
Muine Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-15 11:42 UTC by Christian Neumair
Modified: 2006-10-12 22:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Proposed patch (7.96 KB, patch)
2006-08-15 11:45 UTC, Christian Neumair 		none Details | Review

Description Christian Neumair 2006-08-15 11:42:28 UTC 
libmuine uses the gnome-vfs API without error checking and passes invalid URIs (which are actually filenames) to gnome_vfs_uri_new, which used to work because GnomeVFS didn't check its input arguments properly.
Comment 1 Christian Neumair 2006-08-15 11:45:43 UTC 
Created attachment 70939 [details] [review]
Proposed patch

The attached patch clarifies the use of variable names (except for gst player's private current_file variable, which could be renamed to current_uri) and adds proper error checking. Compiling and running muine still spits errors for me, possibly because PlaylistWindow uses file names where it should use URIs for OpenPlaylist() and friends.
Comment 2 Wouter Bolsterlee (uws) 2006-09-29 15:52:04 UTC 
Bug #161930 is related.
Comment 3 Christian Neumair 2006-10-12 21:31:06 UTC 
Ping.
Comment 4 Wouter Bolsterlee (uws) 2006-10-12 22:13:52 UTC 
Fixed, thanks.

2006-10-13  Wouter Bolsterlee  <wbolster@gnome.org>

    * libmuine/metadata.c: (assign_metadata_mp3),
    (assign_metadata_mp4), (assign_metadata_ogg),
    (assign_metadata_flac), (metadata_load):
    * libmuine/player-gst-0.8.c: (player_set_file):
    * libmuine/player-gst.c: (player_set_file):
    * libmuine/player-xine.c: (player_set_file):
    Don't abuse gnome-vfs API and rename some variables to a
    sane name. Fixes bug #351435, patch by Christian
    Neumair.