After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351087 - Port gnome-system-monitor to use the single-instance application library
Port gnome-system-monitor to use the single-instance application library
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: GNOME 3.2
Assigned To: System-monitor maintainers
System-monitor maintainers
: 576455 646502 (view as bug list)
Depends on:
Blocks: 351092 674949
 
 
Reported: 2006-08-12 20:17 UTC by Vytas
Modified: 2012-09-28 05:17 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
gnome-system-monitor-2.15.90.diff (5.47 KB, patch)
2006-08-12 20:18 UTC, Vytas 		none Details | Review
Port to GtkApplication (51.56 KB, patch)
2012-09-19 16:17 UTC, Stefano Facchini 		accepted-commit_after_freeze Details | Review
Make the main window a GtkApplicationWindow (2.99 KB, patch)
2012-09-19 23:08 UTC, Stefano Facchini 		accepted-commit_after_freeze Details | Review

Description Vytas 2006-08-12 20:17:38 UTC 
As a Google Summer of Code participant I am developing a library for GNOME
single-instance applications, and it has reached the state when it can be tested with various applications.

I have ported gnome-system-monitor and attach the patch below. One would also need to copy libguniqueapp code to the gnome-system-monitor directory, changing @GTK_CFLAGS@ to @PROCMAN_CFLAGS@ etc. I have produced a small tarball, which is ready to drop in for testing: http://guniqueapp.akl.lt/patches/libguniqueapp-0.4-for-g-s-m.tar.bz2
Comment 1 Vytas 2006-08-12 20:18:46 UTC 
Created attachment 70792 [details] [review]
gnome-system-monitor-2.15.90.diff
Comment 2 Benoît Dejean 2006-08-12 20:33:31 UTC 
I'll test it but as long as guniqueapp is not desktop/platform i think i'll stay with bacon. Anyway, I may switch to guniqueapp for 2.18. Good job.
Comment 3 Chris Kühl 2011-02-14 16:16:28 UTC 
This should use GtkApplication now that that functionality is in gtk+.
Comment 4 Chris Kühl 2011-04-02 07:49:07 UTC 
*** Bug 646502 has been marked as a duplicate of this bug. ***
Comment 5 Robert Roth 2011-07-08 20:55:15 UTC 
Gtk::Application class isn't included in gtkmm 3.0, the C++ version of GTK+, which the system monitor is written with, will hopefully be included in gtkmm 3.2, this will have to wait until then.
Comment 6 Robert Roth 2012-07-24 20:31:51 UTC 
*** Bug 576455 has been marked as a duplicate of this bug. ***
Comment 7 Stefano Facchini 2012-09-19 16:17:00 UTC 
Created attachment 224767 [details] [review]
Port to GtkApplication
Comment 8 Robert Roth 2012-09-19 17:39:53 UTC 
Review of attachment 224767 [details] [review]:

Nice, it works as it should, libbacon removed, gtkapplication works, single-instance works correctly, command line options work. I will commit it as soon as the hard code freeze ends, that is, after 3.6.0 stable release after 26th of September.
Comment 9 Stefano Facchini 2012-09-19 23:08:07 UTC 
Created attachment 224787 [details] [review]
Make the main window a GtkApplicationWindow

There is also this. Probabily to be squashed with the other patch.
Comment 10 Robert Roth 2012-09-20 17:39:42 UTC 
Review of attachment 224787 [details] [review]:

Looks fine, works as expected, will commit it after the hard code freeze ends.
Comment 11 Robert Roth 2012-09-27 20:26:13 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 12 Stefano Facchini 2012-09-27 21:43:28 UTC 
Robert it seems that you forgot to actually commit the changes to:

data/interface.ui
src/interface.cpp
src/interface.h

and the whole src/procman-app.{cpp,h}
Comment 13 Robert Roth 2012-09-28 05:17:50 UTC 
Thanks... my bad... now it should be OK.