GNOME Bugzilla – Bug 350773
Transcode operates on files with no extension
Last modified: 2007-02-21 17:07:48 UTC
Refer to http://mail.gnome.org/archives/banshee-list/2006-July/msg00120.html for the impetus for this bug report. Summary follows: As I understand it, in Dap.cs, Banshee takes the list of all tracks that are supposed to be on the device (including those that are already on the dap added by loading the database) and sends them all to transcode. Transcode skips any files that have an acceptable extension. Finally, the core invokes the Dap's own Synchronize method which can then discriminate between tracks on the unit and those that need to be added. On the iPod and other players, this doesn't matter because the files on the device retain their extensions. However, on the Karma, all uploaded files get renamed to a number without an extension. Transcode() will then deem that these are not 'acceptable' (even though they are on the device), so it will then do a pointless transcode, storing the newly transcoded file on the device as cached_filename. I have a patch which first checks to make sure that files input into transcode are 'known' file formats; i.e. the file has to have an extension of mp3 or wav or whatever to be considered for transcoding. This will exclude files already on the Karma from being transcoded since they don't have extensions. I'll attach this. This is really the only thing lacking to make the Rio Karma DAP plugin work.
Created attachment 70662 [details] [review] Check for a known extension before transcoding something
Created attachment 76340 [details] [review] Check for known extensions before transcoding
Created attachment 80217 [details] [review] Rebased to subversion of 01/13/2007
component should be changed to karma
The bug 348730 was blocked by this one and that has been resolved; however, this bugs latest patch is newer than the resolution of that bug. Either I'm confused or there is a conflict in information here. Bob could you clarify and if the patch still needs to be applied, confirm that it is good on SVN? I'll add abock to the CC if this is still unresolved so he'll get the update.
AFAIK this patch still needs applying, or a different approach should be taken. The patch in bug 348730 was applied and gives users the ability to play tracks from the DAP and sync -- *if* they delete all of the files on the device first. The problem is that if they sync and there are files on the Karma, it will unnecessarily transcode those files on the device because they have no extension and the transcoder uses the extension to decide whether to transcode it. IMO the transcode shouldn't consider the files that are on the device at all, and the fact that it works for ipod and all the rest is a happy accident. As for alternate approaches, adding a flag to DapTrackInfo to know whether the song is on the device, or calling back into the dap plugin to ask if a file should be transcoded, either of these would work for me. I'll code them up if abock has any input. If the approach of the patch below is deemed ok, then I'll rebase it in a day or two.