After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350176 - sidebar's close icon should be smaller
sidebar's close icon should be smaller
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 350190
Blocks:
 
 
Reported: 2006-08-06 18:55 UTC by Baptiste Mille-Mathias
Modified: 2006-08-11 12:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
just a screenshot with the difference of size (4.77 KB, image/png)
2006-08-06 19:00 UTC, Baptiste Mille-Mathias 		Details

Description Baptiste Mille-Mathias 2006-08-06 18:55:53 UTC 
Hello,

I don't know if there is a "standard" on the size of the sidebar close button, but the size of the icon totem uses is a bit big, specially because nautilus and gedit use a smallest version.
Comment 1 Baptiste Mille-Mathias 2006-08-06 19:00:11 UTC 
Created attachment 70329 [details]
just a screenshot with the difference of size
Comment 2 Bastien Nocera 2006-08-06 19:46:37 UTC 
We use the GTK_ICON_SIZE_SMALL_TOOLBAR size:
        image = gtk_image_new_from_stock (GTK_STOCK_CLOSE,
                                          GTK_ICON_SIZE_SMALL_TOOLBAR);
gedit uses GTK_ICON_SIZE_MENU size.

IMO Small toolbar is the right size to use, which gedit should use, and your theme should be fixed to use decent sizes for those (they probably made _SMALL_TOOLBAR the same size as _LARGE_TOOLBAR).

evince also uses GTK_ICON_SIZE_SMALL_TOOLBAR. Nautilus also uses GTK_ICON_SIZE_MENU.

So you need to:
- file a bug against your icon theme
- get either gedit and nautilus to switch sizes, or evince and totem (don't really care about changing Totem, just point me to the evince bug number).


bug 307044 is about providing a sidebar widget in gtk+.
Comment 3 Nickolay V. Shmyrev 2006-08-11 05:35:27 UTC 
I like SIZE_SMALL_TOOLBAR in evince too. GEdit will have problems with it since they use same icon in tab labels, so I wonder if it's possible to change this in gedit. And we have to be consistent with file selector (See bug 165770).
Comment 4 Nickolay V. Shmyrev 2006-08-11 05:37:57 UTC 
Anyhow, I've changed sidebar icon size in evince.
Comment 5 Bastien Nocera 2006-08-11 12:49:59 UTC 
2006-08-11  Bastien Nocera  <hadess@hadess.net>

        * src/ev-sidebar.c: (ev_sidebar_init): Use a
        GTK_ICON_SIZE_MENU close button (Closes: #350176)