GNOME Bugzilla – Bug 343186
configure.in creates an AC_SUBST race on VERSION
Last modified: 2006-06-18 21:31:14 UTC
Hi, Totem will fail to build with autoconf 2.59 because of: AC_DEFINE(VERSION, AC_PACKAGE_VERSION, [package version]) AC_SUBST(VERSION) which results in: #define VERSION 1.5.x instead of: #define VERSION "1.5.x" I've filed a bug against autoconf suggesting this might be a regression, but got tons of useful information from Ralf Wildenhues pointing out mistakes of the current configure.in script. (Full log in http://bugs.debian.org/368877.) First, this should have been: AC_DEFINE(VERSION, "AC_PACKAGE_VERSION", [package version]) or: AC_DEFINE_UNQUOTED(VERSION, "$VERSION", [package version]) Second, since VERSION is already defined by automake, this causes the replace to be attempted twice in config.status, and that's why this comes out with autoconf 2.59 which makes the order of the subst differents. That's why you should drop it altogether. This seems to have been introduced to workaround an automake bug fixed in 1.7.3, it would have been best to require this version or higher instead of introducing the workaround. I'll attach a patch removing these two lines and solving the build failure here. This bug is present in 1.4 too. Bye,
Created attachment 66368 [details] [review] Fix AC_SUBST race exposed by autoconf 2.59
Ralf proposed other improvements as well: 1/ he suggests replacing AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION) by a simple AM_INIT_AUTOMAKE; in CVS, there are two AM_INIT_AUTOMAKE calls, I'd keep only the second one 2/ he suggests using "AUTOMAKE_OPTIONS = 1.6" in Makefile.am for backward compatibility with older automakes (I suppose you can make that 1.8 given the AM_INIT_AUTOMAKE call in CVS) 3/ On my part, I'd also suggest dropping the AC_DEFINE(PACKAGE, AC_PACKAGE_NAME, [package name]) part, and using PACKAGE_NAME instead, which is defined by automake. Please comment on these proposals, and I'll provide a patch covering them.
Don't care, either way, just make sure that everything that worked still works.
My fault. This is fixed now, as we changed the apps to use PACKAGE_VERSION instead of VERSION. *** This bug has been marked as a duplicate of 344599 ***