GNOME Bugzilla – Bug 343108
Consider replacing changing menu-item text with checkboxes or a pair of items
Last modified: 2006-11-15 16:16:55 UTC
The "Show on all workspaces" menuitem in a window's context menu should be a checkbox, just like the "Always on top" item. Right now the item changes it text (BAD UI! BAD UI! BAD UI! ;->) when it is selected.
Dude, you need to upgrade. "Show on all workspaces" was renamed quite a while ago. Still valid though, and, of course, there's the same problem in libwnck for the right-click on task menu. Opinion of the usability experts?
Elijah, I'm running HEAD but in the nl_NL locale so I made an ad-hoc translation without checking the source; I'm lazy and it's irrelevant ;-)
Oh, I see. Sorry for jumping to conclusions. :)
Following the HIG's guidance here, if we're moving away from the changing-label model, there's more likely a case for using two radiobutton menu items instead of a checkbox, as the two states aren't naturally opposite. I.e. if I had "Always on visible workspace" unchecked, that could mean "never on visible workspace", or "always on other workspaces", or "sometimes on visible workspace depending on the outcome of a random number" :) http://developer.gnome.org/projects/gup/hig/2.0/menus-design.html#menu-item-types
The random number solution is clearly correct here.
What about the menu changing itself depending on what you choose? If you select "Always on Visible Workspace," then the item "move to workspace to the right/left/up/down" and the submenu "move to another workspace" disappears. Does something need to be done about that? It is not 100% robust IMHO.
Also worth noting is that minimize/unminimize (okay, so that one is only noticable in libwnck) and maximize/unmaximize are two other items in the menu that change form. If we're going to get rid of changing text in the menu, those need to be modified too.
I'd like to implement this. Can I use radiobuttons?
I have been attached a patch to fix it and bug #342123. http://bugzilla.gnome.org/attachment.cgi?id=74851&action=view
Elijah: If you commit this, I'll open a bug to fix it in libwnck too.
Patch updated... (I forgot a detail in previous...) http://bugzilla.gnome.org/attachment.cgi?id=74901&action=view