GNOME Bugzilla – Bug 341899
Message showing background image size and type is not localized
Last modified: 2007-01-08 17:54:22 UTC
In gnome-background-properties, the high-level message showing the image type and size is not marked for localization. The message is "%s, %d %s x %d %s". This messages needs to be localized as: 1) Some languages like Persian and Arabic use another character for comma. 2) RTL langauges will need to add bidirectional marks around some parts to get a proper rendering of the message. 3) Some languages may prefer to localize "x" to a proper MULTIPLICATION SIGN (U+00D7). 4) Some langauge like Persian may need to localize %d to %Id in order to use localized digits. The bug still exists in HEAD. Will attach a patch. FarsiWeb's internal reference: bug #265, control-center-persian-digits.patch, originally reported by Behdad Pournader, patch by Roozbeh Pournader
Created attachment 65541 [details] [review] Patch against head to fix the problem, only tested on 2.10.1
Looks good to me. I wanted to say I prefer a context string, but that makes it more error prune I guess. Roozbeh: In GNOME we typically retain the asterisk at the left margin of comment blocks.
Created attachment 65556 [details] [review] better patch, using Q_
(In reply to comment #2) > Looks good to me. I wanted to say I prefer a context string, but that makes it > more error prune I guess. But we should really have it that way. I changed my mind and did it this way even before seeing your comment. Anyway, the first patch will probably not work, since nothing that defines _() is included. > Roozbeh: In GNOME we typically retain the asterisk at the left margin of > comment blocks. Ah, I just followed the style of the rest of the file.
any progress here?
Apparently this was already committed without my approval, and the person didn't update the bug report. :(
well, no feedback sometimes results in no feedback. *shrug*
Well, it wasn't Roozbeh or Bedhad. It was an arbitrary third party, never involved in the bug, and whom I've never even heard of. I will have to e-mail them privately.
uhm, okay, that's a different case then.