After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340204 - [patch] Improve the look & feel of combo boxes (with patch files)
[patch] Improve the look & feel of combo boxes (with patch files)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.8.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
: 407464 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-30 15:53 UTC by Hong Jen Yee
Modified: 2007-02-20 11:11 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch for GtkComboBox. (1.13 KB, patch)
2006-04-30 15:54 UTC, Hong Jen Yee
none Details | Review

Description Hong Jen Yee 2006-04-30 15:53:32 UTC
I adjusted the width of the drop down list.
Under Windows, the drop down list of combo boxes should be as
wide as the combo box itself. So, I use combo box as sample
when positioning the list instead of original GtkFrame.

Besides, change frame type of GtkFrame to none because drop down 
lists under Windows have flat borders.
Comment 1 Hong Jen Yee 2006-04-30 15:54:39 UTC
Created attachment 64575 [details] [review]
Patch for GtkComboBox.
Comment 2 Tor Lillqvist 2006-05-02 08:27:14 UTC
Like in bug #340206, the appearance should depend on whether the ms-windows ("wimp") theme is in use or not, shouldn't it?

Or should we make wimp always be active and not deconfigurable at all? Personally I don't think I would mind, but some people might prefer to have the default cross-platform look in some apps?
Comment 3 Dominic Lachowicz 2006-05-02 12:18:04 UTC
In my opinion, the way to proceed here is to add a style property that says whether the dropdown list should be as wide as the combo box, defaulting to FALSE. There should also be a setting for the frame's shadow type *if and only if* it isn't possible to set from the gtkrc or override through msw_style.c.
Comment 4 Matthias Clasen 2006-05-02 12:49:01 UTC
in my opinion, the appears-as-list style should match as closely as
possible whatever is considered to be the "Windows way" of doing
combo boxes (I'm sure it has changed over time...).

So, if wide popups are the correct behaviour for combo boxes on
windows, appears-as-list should just do that. 
Comment 5 Dominic Lachowicz 2006-12-15 19:08:24 UTC
Fixed. Thanks.
Comment 6 Kristian Rietveld 2007-02-20 11:11:52 UTC
*** Bug 407464 has been marked as a duplicate of this bug. ***