GNOME Bugzilla – Bug 339820
Muine should remember main window position
Last modified: 2008-09-28 00:21:48 UTC
Please describe the problem: Muine should remember main window position between launches, so it appears always in the same position, defined by the user. Steps to reproduce: 1. Launch Muine (it appers anywhere in screen) 2. Move Muine to top right corner on screen 3. Quit Muine and relaunch it 4. Muine appers anywhere in the screen, not top right corner Actual results: Expected results: Does this happen every time? Yes Other information:
Created attachment 64414 [details] [review] Patch to add support for remembering window position I know a patch for this was sent to mailing list long ago (2004, i think). Don't know why it never got upstream. So I'm submitting this patch against current cvs to add support for remembering window position between launches.
This is not a bug IIUC - as per window-manager specifications (or maybe HIG - I don't recall the exact document) apllications SHOULD NOT handle window positioning themselves since this is the task of the window manager. The only window-geometry related thing applications should do is remembering/restoring window sizes which is not a problem with muine.
lots of applications have window X and Y co-ordinates, some store it in gconf other in .gnome2/
*** Bug 155044 has been marked as a duplicate of this bug. ***
Jorn Baayen writes in bug #155044: > Will be done as soon as there is way to use popt in C#..
Changing component. Filter "uws doing muine component triaging" to get rid of the spam. Thanks!
Ok, this shouldn't be done by Muine. Closing.
(In reply to comment #7) > Ok, this shouldn't be done by Muine. Closing. I don't understand why this is not gonna happen in Muine. Almost every other media player has this feature: Rhythmbox: gconf/apps/rhythmbox/state/window_position_x and window_position_y Other audio apps that remember position: xmss, mesk, beep-media-player, banshee... Lots of apps (not only audio ones) remember position on screen. I think muine should do it as well.
Doing this well is extremely hard (e.g. multi-monitor setups that have changed, different resolutions, and so on), and shouldn't be done by an application. At least, that's my opinion. Feel free to reopen if you disagree so that others can discuss as well.
(In reply to comment #9) > Doing this well is extremely hard (e.g. multi-monitor setups that have changed, > different resolutions, and so on), and shouldn't be done by an application. At > least, that's my opinion. Feel free to reopen if you disagree so that others > can discuss as well. As far as i now, if you manually move a window using gtk.window.move(), if you give coordinates that are not correct (out of screen or whatever), metacity puts the window on the nearest corner, so i don't think different resolutions or multi-monitor setups are a problem. BTW, i can not reopen the bug (privileges?)
(In reply to comment #10) > BTW, i can not reopen the bug (privileges?) Oh well. I'll do it.
I'm not sure if we can add this feature or not. Apparently the patch works on multi-monitor the windowmanagers are ready to deal with this. The patch looks good for me and i took at look and banshee uses this as well. Imo it's safe to use this .
(In reply to comment #12) > I'm not sure if we can add this feature or not. Apparently the patch works on > multi-monitor the windowmanagers are ready to deal with this. The patch looks > good for me and i took at look and banshee uses this as well. Imo it's safe to > use this . Luis, if you're confident this works, please commit.
Created attachment 119175 [details] [review] Updated patch against svn trunk (2008-09-28)
Thanks. A few comments: - Is the GConf value updated at every pixel of movement/resizing? If so, please add a delay to avoid excessive GConf traffic. - Also, the .schemas part of the patch is missing.
Created attachment 119216 [details] [review] Updated patch against svn trunk (2008-09-23) Well, in fact this patch saves the position of the window when exiting muine, to avoid doing it in every window configure_event, I don't know if this is ok. The schemas stuff is now added to the patch.
Looks good, please commit with a ChangeLog message.
Well, I don't have permissions to commit, just an user...
Commited to svn trunk Thanks a lot for the patch. 2008-09-28 Luis Medinas <metalgod@gnome.org> * data/muine.schemas.in: * src/PlaylistWindow.cs: Fix main window position after quit muine. Closes bgo #339820. Patch from Adolfo Blásquez <code@infinicode.org>."