GNOME Bugzilla – Bug 339093
shortcuts conflict in composer: control + 8
Last modified: 2008-03-27 10:31:34 UTC
in the composer, the shortcut Control+0 is both used for "HeadingNormal" format and "TextZoomReset" to chance the text zoom. => currently i can change the text zoom by "control"+"+", but i cannot reset it to the default zoom. proposal: change "HeadingNormal" to Control+9 which is currently unused. not that cool, but no idea otherwise. :-/
Hmm, I disagree with the proposed fix. IMHO there is absolutely no reason to support changing a zoom level in the Composer. If changing this would be useful, the user is using a bad font size he should not use and most likely doesn't even want to use. The point is, if I can't read what I type, how could I possibly expect the recipient to? My proposal would be to nuke the shortcuts for the zoom level entirely. Note that this is a hidden gimmick, which is not available from any menu anyway. I assume this "feature" went in by accident. Honestly, I didn't even know this is possible till now... On the other hand, Ctrl-0 is used for Paragraph Style "Normal" for a long time already. Also, this is the Composer. GtkHTML/Editing. Dude... ;-)
Andre, It's Ctrl + 9 that is used to reset zoom.
rohini, yes, but is that intentional? see bug 317386. where is this shortcut located in the code? i'm unable to find it. even if the zoom is set to default by using control+9 (in composer) instead of control+0 (like it's in evo), we have the conflict that control+8 both means "HeadingAddress" and "text zoom-in", as it was in former times before we changed over to use control++ to keep consistency. so "HeadingAddress" does not work. /me slightly modifies the subject, dumdidum... s/0/8 guenther: right. let's REMOVE text zoom in composer. but only after providing a howto here how to set the text size in composer. ;-)
ctrl + 0 conflicts with zoom out and normal. Because there's already a keybinding for zoom in and zoom out. Removing the keybinding Ctrl+8 and Ctrl+0 for zoom would be sufficient.
Created attachment 63936 [details] [review] patch
The patch provided nukes the conflicting entries but does not necessarily remove the ability to zoom in/out as Karsten has suggested. I'd agree with that rationale.
rohini: can you update the patch, please?
Created attachment 107075 [details] [review] proposed gtkhtml patch (updated one) for gtkhtml; Let's see if someone will yell after this patch applied :)
milan, the patch means that zooming still works for the main window (not composer), right? if so, it looks useful.
Nope, it was the thing I didn't understand completely, so this short cut can only work in non-composer, hmm, I should change the patch then.
It will be a gross hack, really. I cannot remove the binding based on the is_editable value, because the binding is for the class, not for the object. Really nice. So some hack for 'command' function with indication whether command comes from the binding or not and if yes, then ignore it in editable mode. It will be wondefull :)
Created attachment 107140 [details] [review] proposed gtkhtml patch ][ for gtkhtml; The hack as I wrote above.
Seems fine. Commit to trunk.
Committed to trunk. Committed revision 8792.