After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333998 - more fun with ampersands: file monitoring
more fun with ampersands: file monitoring
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Importing
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 335598 337047 349378 362149 543117 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-09 10:47 UTC by Jonathan Matthew
Modified: 2008-07-15 21:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
annoying patch (2.40 KB, patch)
2006-03-16 11:54 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2006-03-09 10:47:34 UTC 
Files that we first become aware of through file monitoring events get added twice.  I haven't looked very closely, but I suspect the file URI that gnome-vfs gives us (probably) has & encoded as %26.  Some sequence of badness follows, wherein the entry with %26 is added, a stat is queued, it gets translated to &, and another entry is added.  Probably.
Comment 1 Jonathan Matthew 2006-03-16 11:54:34 UTC 
Created attachment 61356 [details] [review]
annoying patch

Our problems with & (and =) arise from the fact that gnome_vfs_escape_path_string doesn't encode them, but gnome_vfs_uri_new does (in a block of code marked as a 'quick hack' that has been there since 2.12 ..).

This patch makes rb_canonicalise_uri specifically encode these characters, and bumps the rhythmdb file version to 1.2, causing entries from 1.1 to be canonicalised again.  This makes it possible for us to use URIs returned by gnome-vfs.
Comment 2 James "Doc" Livingston 2006-03-17 07:33:10 UTC 
Looks good to me.
Comment 3 Jonathan Matthew 2006-03-19 11:30:51 UTC 
committed.
Comment 4 Alex Lancaster 2006-03-23 04:36:12 UTC 
*** Bug 335598 has been marked as a duplicate of this bug. ***
Comment 5 Alex Lancaster 2006-04-04 03:11:03 UTC 
*** Bug 337047 has been marked as a duplicate of this bug. ***
Comment 6 Alex Lancaster 2006-07-31 08:46:28 UTC 
*** Bug 349378 has been marked as a duplicate of this bug. ***
Comment 7 Alex Lancaster 2006-10-15 01:06:28 UTC 
*** Bug 362149 has been marked as a duplicate of this bug. ***
Comment 8 Jonathan Matthew 2008-07-15 21:42:24 UTC 
*** Bug 543117 has been marked as a duplicate of this bug. ***