After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329100 - Choosing adress book for birthdays
Choosing adress book for birthdays
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.4.x (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 267428 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-29 16:58 UTC by paolo
Modified: 2009-10-13 15:28 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
proposed eds patch (7.85 KB, patch)
2009-07-20 18:07 UTC, Milan Crha 		committed Details | Review
proposed evo patch (3.58 KB, patch)
2009-07-20 18:09 UTC, Milan Crha 		reviewed Details | Review
proposed evo patch ][ (3.35 KB, patch)
2009-09-23 13:29 UTC, Milan Crha 		committed Details | Review

Description paolo 2006-01-29 16:58:38 UTC 
Because I have an adress book ldap.backup which holds just a backup of the ldap 
list, I have all birthdays twice. I even would like to have some more backup 
folders if I can choose the adress book used for birthday entries in the 
calendar.
Comment 1 Milan Crha 2009-07-20 14:11:42 UTC 
*** Bug 267428 has been marked as a duplicate of this bug. ***
Comment 2 Milan Crha 2009-07-20 18:07:09 UTC 
Created attachment 138835 [details] [review]
proposed eds patch

for evolution-data-server;
Comment 3 Milan Crha 2009-07-20 18:09:05 UTC 
Created attachment 138836 [details] [review]
proposed evo patch

for evolution;

I added this to the default-source plugin, as it doesn't worth it to add a new plugin for it.

It's new string and UI change, thus, at least the evo part, should wait a bit.
Comment 4 Chenthill P 2009-08-03 14:39:03 UTC 
Patch looks good. But default-source plugin is meant for a different purpose and not a right place for it. I am not able to find a plugin to which this can be added into... If you find one, please add or maybe a new one is better.
Comment 5 Tobias Mueller 2009-09-16 22:55:44 UTC 
Hey Milan, Chen.
I think we can commit both patches now, no?
Comment 6 Chenthill P 2009-09-17 07:08:15 UTC 
Not both as per comment #4. We had a discussion over irc on using the existing plugin. I still feel using the existing one is not a good option.
Comment 7 Milan Crha 2009-09-23 10:49:57 UTC 
Chen, what about having the evo part not as a plugin, but as a core code? I'm not much willing to create a new plugin only because of this. As we enforce B&A calendar, the plugin for it only has not much sense.
Comment 8 Milan Crha 2009-09-23 13:29:27 UTC 
Created attachment 143790 [details] [review]
proposed evo patch ][

for evolution;

updated patch.
Comment 9 Chenthill P 2009-10-13 09:37:53 UTC 
Comment on attachment 143790 [details] [review]
proposed evo patch ][

Fine with it. But just add a todo comment stating this needs to be moved to plugins if B&A calendar setup is moved there.
Comment 10 Chenthill P 2009-10-13 09:37:57 UTC 
Comment on attachment 143790 [details] [review]
proposed evo patch ][

Fine with it. But just add a todo comment stating this needs to be moved to plugins if B&A calendar setup is moved there.
Comment 11 Milan Crha 2009-10-13 15:28:06 UTC 
Created commit d831977 in eds master (2.29.1+)
Created commit 2efaad9 in evo master (2.29.1+)