After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323400 - Use 'folder' instead of 'directoy'
Use 'folder' instead of 'directoy'
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-06 20:48 UTC by Jorge González
Modified: 2006-09-26 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
one liner patch (1.56 KB, patch)
2006-09-23 13:05 UTC, Bengt Thuree
committed Details | Review

Description Jorge González 2005-12-06 20:48:02 UTC
It would be nice to use folder instead of directory in the strings of the pot file.

Other information:
Comment 1 Gabriel Burt 2005-12-13 02:56:42 UTC
The Style Guide
(http://developer.gnome.org/documents/style-guide/gnome-glossary-generic-terms.html)
makes a distinction between the two, and goes so far as to give an example that
uses both in a single (apparently user-facing) sentence, but I think you're
right, that "directory" does not belong in F-Spot (although according to the
style guide it may be appropriate when talking about the ~/Photos/ directory).
Comment 2 Gabriel Burt 2005-12-16 09:02:51 UTC
Here's a list of places that directory is used.  Larry, what do you think about
changing these all to "folder"?  I think that, according to the style guide, we
should keep the term directory where we also give the path, but use the term
folder otherwise.

CameraFileSelectionDialog.cs:           Mono.Posix.Catalog.GetString ("Unable to
create directory."),
CameraFileSelectionDialog.cs:           String.Format
(Mono.Posix.Catalog.GetString ("Error \"{0}\" while creating directory \"{1}\".
 Check that the path and permissions are correct and try again"), e.Message,
destination));
Exif.cs:                                return Mono.Posix.Catalog.GetString
("Image Directory");
Exif.cs:                                return Mono.Posix.Catalog.GetString
("Thumbnail Directory");
Exif.cs:                                return Mono.Posix.Catalog.GetString
("Exif Directory");
Exif.cs:                                return Mono.Posix.Catalog.GetString
("GPS Directory");
Exif.cs:                                return Mono.Posix.Catalog.GetString
("InterOperability Directory");
Exif.cs:                                return Mono.Posix.Catalog.GetString
("Unknown Directory");
GPhotoCamera.cs:                        throw new Exception (String.Format
("Directory \"{0}\"does not exist", filename)); //FIXME
MainWindow.cs:                          Gtk.Window win = new Gtk.Window
("Directory View");
ImportCommand.cs:                       Mono.Posix.Catalog.GetString ("Directory
does not exist."), ImportCommand.cs:                       String.Format
(Mono.Posix.Catalog.GetString ("The directory you selected \"{0}\" does not
exist.  Please choose a different directory"), this.ImportPath));
Comment 3 Larry Ewing 2006-03-15 18:58:09 UTC
the stuff in Exif.cs is not about the filesytem at all so it is outside this scope.  The the things in ImportCommand and CameraFileSelectionDialog are reporting the full patch of something that is missing so they seem sane wrt using Directory as the term.  And the instance in MainWindow is not actually used anywhere iirc.  so I'm not too worried about any of this.  Did you check the glade file for other possible problems?
Comment 4 Bengt Thuree 2006-05-18 02:26:15 UTC
So should we close this one, as WontFix
Comment 5 Bengt Thuree 2006-09-23 13:05:35 UTC
Created attachment 73271 [details] [review]
one liner patch

A small patch to replace the only occurance of Directory to Folder in f-spot.glade

This replaces the f-spot --view  --> Directory in the top left corner, with Folder.
Comment 6 Larry Ewing 2006-09-26 18:27:11 UTC
fixed in CVS