GNOME Bugzilla – Bug 322436
Build failure using latest DBUS
Last modified: 2005-11-28 18:37:34 UTC
totem-mozilla-viewer.c:74: warning: no previous prototype for ‘totem_embedded_get_type’totem-mozilla-viewer.c: In function ‘main’: totem-mozilla-viewer.c:505: error: ‘DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT’ undeclared (first use in this function) totem-mozilla-viewer.c:505: error: (Each undeclared identifier is reported only once totem-mozilla-viewer.c:505: error: for each function it appears in.) make[4]: *** [totem-mozilla-viewer.o] Error 1 make[4]: Leaving directory `/home/luca/tmp/cvs/gnome2/totem/src' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/luca/tmp/cvs/gnome2/totem/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/luca/tmp/cvs/gnome2/totem/src' make[1]: *** [all-recursive] Error 1 It seems related to a change in DBUS: 2005-11-22 John (J5) Palmieri <johnp@redhat.com> * configure.in: Add test/name-test/Makefile to the generated Makefile list * dbus/dbus-shared.h (#define DBUS_NAME_FLAG_ALLOW_REPLACEMENT): New flag which replaces DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT (#define DBUS_NAME_FLAG_DO_NOT_QUEUE): New flag for specifying not to queue an ower if it can't be the primary owne
Forgot to mention: 2005-11-22 John (J5) Palmieri <johnp@redhat.com> * configure.in: - Change version to 0.60 for impending release - upped the sonames because of ABI and API breakage
Created attachment 55252 [details] [review] totem-new-dbus.patch
I guess that DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT is the new "default", and we should simply ignore its use if it doesn't exist. Is this right?
Dunno, but gnome-power-manager has the same issue (see bug #322435). By now I still have to make my fresh jhbuild install works with DBUS, so I can't really test it (compilation only)
>I guess that DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT is the new "default", and we >should simply ignore its use if it doesn't exist. Is this right? Yes, just replace it with 0. See http://bugzilla.gnome.org/attachment.cgi?id=55247&action=view Richard.
Committed to gnome-2-12 and HEAD 2005-11-28 Bastien Nocera <hadess@hadess.net> * src/totem-mozilla-viewer.c: fix compilation with newer versions of D-Bus (Closes: #322436)