GNOME Bugzilla – Bug 317257
MP3 profile should be included in default install
Last modified: 2007-01-06 23:34:02 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/show_bug.cgi?id=16328 "An mp3 profile for cd ripping should be included by default. Preferably it should autodetect the presence of gstreamer-lame, otherwise it could just be included as not active. Right now it is far too difficult to get sound-juicer to rip to mp3, and the user shouldn't be confronted with the technical details mentioned in the help file to get it to work."
It should not be default. I am shocked a Humanity-to-all-user would propose chaining us to a patented format.
have you read the bug description before commenting? Do you know what a profile is?
I support Sebastien here. The ipod has such a large marketshare that we cannot just say "use ogg" and be done with it. The real world is out there, and it's not happy.
It's a shame that some laws of physics, as in algorythms for sampling data, and mp3 encoding, are hyjacked through propriority rights and such. The propriority rights should be limited to not cover an entire range of concept. JWM
Indeed, iPod has at this moment sold roughly 70 million units. Combine that with the other brands and there are likely way past 500 million players on the planet, of which only a handful (less than a million most likely) knows OGG or some other free format. I'd like to live in a perfect world myself too but as it doesn't seem to exist we will have to deal with the situation. At this moment millions of Linux users will have to manually find out obscure gstreamer configuration line and feed it to Sound Juicer - just to get a basic mission critical task the application was CREATED FOR to work. Without doing that they will be ripping into a format they can not listen and it is not acceptable. Furthermore I can claim that not implementing the feature hurts OGG more than it helps. The more people get fed up with Linux distributions not working out of the box in a sane way the more they turn back to using Windows XP and Vista. It's a fact. And Windows Media player with wma/mp3 will be their natural choice anyways. Or iTunes and the aac. I would respectably suggest the developers to take their ideological battle elsewhere, stop hurting ordinary people, and implement the feature in upstream. It's roughly dozen lines of code anyways (check gst whether mp3 handler has been registered, if not then do not show the line, if is then show the line on the dropdown list).
Anlar, this is up to the developers. I'm the maintainer of this product, so it will get in there. However, populistic comments like this don't help. Contributing code quite definitely works a lot better. If you want to know how I want to see this done, contact me and I'll help you get it going and I'll apply the patch. I won't take the patch as you suggest it, that is not how the profile chooser works or how it should work.
I made my comment because of the earlier 3 populistic comments. Sorry about that.
That's OK; try to contribute if you can, it's usually more productive. :-). It'll be done, I just can't quite promise when it'll be done.
(In reply to comment #6) > If you want to know how I want to see this done, contact me and I'll help you > get it going and I'll apply the patch. I won't take the patch as you suggest > it, that is not how the profile chooser works or how it should work. What patch? If there has been off-bug communication, would you mind summarising it? Surely we just need to patch the schemas to add pipelines for some widely-supported formats?
Created attachment 78837 [details] [review] legacy-profiles.patch MP3 and AAC profiles, disabled by default. What's wrong with this approach? At least this way we standardise the pipelines used.
I want it enabled by default, but not shown if the pipeline (bin) can not be parsed (because elements are missing). If it's disabled, it still requires two steps, which is plain silly. so actions required: - add it, enabled by default, to the defaults - when showing the combobox, parse each entry and see if it parses. If it doesn't, do not show it - in the editor, show a warning below it that it cannot be parsed because elements are missing or because there is a typo in the pipeline description
FWIW, I'd recommend using the maintained and full-featured 'id3v2mux' element from gst-plugins-good instead of the rotten and semi-broken 'id3mux' from -ugly.
*** Bug 338216 has been marked as a duplicate of this bug. ***
Created attachment 79575 [details] [review] better patch This patch does approximately what I want. Installing plugins is enough to get it to show up in s-j now.
2007-01-06 Ronald S. Bultje,,, <rbultje@gnome.org> * configure.in: * profiles/audio-profile.c: (gm_audio_profile_get_active_list): * profiles/gnome-audio-profiles.schemas.in.in: Include AAC and MP3 profiles. Only show profiles if they parse (i.e. if the plugins exist). Fixes #317257. Based on a patch by Ed Catmur <ed@catmur.co.uk>. Applied.
Brilliant, thanks. Note to users and downstream packagers: subpackages required to get legacy-codec audio profiles to show up are: * For MP3: gst-plugins-good/lame, gst-plugins-good/taglib * For AAC: gst-plugins-bad/faac, gst-ffmpeg
W00T. Thanks, Ronald!