GNOME Bugzilla – Bug 317089
Ipod information viewer/editor
Last modified: 2011-07-26 19:46:29 UTC
Rhythmbox should allow to read / edit information about ipod : some thoughts here Edition * owner * Ipod name Information: * Total size * Size available * Some system info (mount pount, ...)
http://banshee-project.org/index.php/Image:Banshee-ipod-properties.png is okay, although I'm not sure how useful "Computer name" is.
Fwiw, libipoddevice from gnome cvs handles all of that.
Created attachment 63721 [details] [review] Work in progress patch Screenshots can be found at http://cfergeau.free.fr/hack/ipod-properties1.png and http://cfergeau.free.fr/hack/ipod-properties2.png
That looks nice. The property dialogue should also be able to change the iPod's name (in the database[1], not the filesystem label) [1]: http://ipodlinux.org/ITunesDB#DeviceInfo_File
is this enhacement dead?
Christophe, Do you still work on that ?
Created attachment 118337 [details] [review] Updated for latest Subversion with a few fixes Needs some work, but works with latest subversion on my 2nd Gen iPod Mini
Hi, sorry for this bit of delay reviewing your patch. Exporting RbIpodDbPrivate is a big no-no, making it private makes the whole thing more maintainable since it guarantees only rb-ipod-db.c will be able to poke into its content. To achieve what you are trying to do, I'd either define a RbIpodInfo structure containing all bits that you need to fill the info dialog and add a rb_ipod_db_get_ipod_info call or I'd add a bunch of accessors for each item you want to put in the ipod info dialog : rb_ipod_db_get_playlist_count and so on.
Created attachment 119343 [details] [review] Changed as per feedback Updated to latest SVN. Changed as per Christophe's suggestions in Comment #8 Only needed to add one function: rb_ipod_db_get_database_version All other functions were currently in rb-ipod-db.c
This looks much nicer :) I haven't tested it yet though, only read the diff and compile-tested. I think the available space (and maybe the total space) on the ipod should be displayed in this dialog (maybe they are already, as I said I only looked through the code so I may have missed some stuff).
Agreed, but I have no idea how to get those through code. The current (at least current on my system) libgpod doesn't seem to show any functions to get this done. gtkpod shows available space, though... hmm... Any idea where I can find updated documentation on libgpod and it's 'released' capabilities?
You can get the information from the GMount after getting the GVolume from the source object.
Created attachment 119867 [details] [review] Patch that applies on top of the earlier patch This patch moves the "model" line from the Basic tab to the Advanced tab. It also add some functions using GIO to get the ipod total space/free space and to get the device name. The function to get the device name is used in the property dialog, the function to get free/total space aren't used yet, maybe you want to add the code to make proper use of them in the dialog ?
Created attachment 119876 [details] [review] Volume usage now shown properly Volume usage is now shown properly (thanks Christophe!) Moved 'Model' to advanced tab as per comment #13
Created attachment 120019 [details] [review] Patch that refines patch #119876 Here is another patch on top of yours. It changes the glade file to add some 12 px padding here and there. The purpose was to make it more HIG-friendly but I'm not really good at that so maybe I got it wrong. I reordered the items in the source popup menu to make it more similar to the one in Nautilus but I ended up with too many separators imo. It also adds stock icons for the "new playlist" and "properties" entry. Finally, the patch uses g_format_size_for_display to display the used/total ipod capacity in the dialog which makes it look much nicer.
Created attachment 120154 [details] [review] Combination of patch 119876 and 120019 Also removed the 'Rename' menuitem in favor of the 'iPod Name' callback in the properties window. Popup menu looks as follows: New Playlist --- Eject --- Properties
Forgot in the above: Removed 'Your Name' item as it is not supported in libgpod (or in the iTunesDB, for that matter). This one looks done to me. JD
Ok, I committed the latest patch : 2008-10-15 Christophe Fergeau <teuf@gnome.org> Patch by: John Daiker * plugins/ipod/Makefile.am * plugins/ipod/ipod-info.glade * plugins/ipod/ipod-ui.xml * plugins/ipod/rb-ipod-db.c * plugins/ipod/rb-ipod-db.h * plugins/ipod/rb-ipod-plugin.c * plugins/ipod/rb-ipod-source.c * plugins/ipod/rb-ipod-source.h: add an ipod properties dialog, fixes bug #317089
John, see bug #558576 if you want to try to improve the volume usage look ;)