After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310883 - Use stock icons for play.png noplay.png record.png norecord.png
Use stock icons for play.png noplay.png record.png norecord.png
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on: 469319
Blocks:
 
 
Reported: 2005-07-19 14:43 UTC by Jaap A. Haitsma
Modified: 2008-03-24 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jaap A. Haitsma 2005-07-19 14:43:03 UTC
That way the mixer is better themeable.
Comment 1 Ronald Bultje 2005-08-08 20:53:53 UTC
Are there pre-made stock icons for that?
Comment 2 Jaap A. Haitsma 2005-08-08 21:47:24 UTC
From gnome-icon-theme you have you could use the following replacements
play.png => stock_volume.png
noplay.png => stock_volume-mute.png
record.png => stock_mic.png
norecord.png => OK that one is still not there, but should not be too difficult
to make. If you think stock icons are a good idea, we could file a request for
such an icon
Comment 3 Ronald Bultje 2005-08-08 22:00:00 UTC
I'd like that, yes. I'll make this bug depend on it and use it when done. Thanks.
Comment 4 Bastien Nocera 2007-08-22 15:09:17 UTC
Jaap, did you file a bug about that?
Comment 5 Jaap A. Haitsma 2007-08-22 17:08:37 UTC
(In reply to comment #4)
> Jaap, did you file a bug about that?
> 

I just did.
Comment 6 Ronald Bultje 2007-08-22 17:16:09 UTC
Could you make this depend on that?
Comment 7 Jaap A. Haitsma 2007-08-22 19:35:21 UTC
This bug already depends on bug 469319. I thought bugzilla sent out a notification for that.
Comment 8 Jaap A. Haitsma 2008-03-24 10:44:49 UTC
2008-03-24  Jaap Haitsma  <jaap@haitsma.org>

        reviewed by: Marc-Andre Lureau

        * configure.in:
        * gst-mixer/Makefile.am:
        * gst-mixer/gnome-volume-control-ui.xml:
        * gst-mixer/icons/16x16/Makefile.am:
        * gst-mixer/icons/16x16/devices/Makefile.am:
        * gst-mixer/icons/16x16/status/Makefile.am:
        * gst-mixer/icons/Makefile.am:
        * gst-mixer/pixmaps/Makefile.am:
        * gst-mixer/src/Makefile.am:
        * gst-mixer/src/button.c: (gnome_volume_control_button_class_init),
        (gnome_volume_control_button_init),
        (gnome_volume_control_button_dispose),
        (gnome_volume_control_button_new),
        (gnome_volume_control_button_clicked),
        (gnome_volume_control_button_mouseover),
        (gnome_volume_control_button_mouseout):
        * gst-mixer/src/button.h:
        * gst-mixer/src/element.c:
        (gnome_volume_control_element_class_init),
        (gnome_volume_control_element_init),
        (gnome_volume_control_element_new),
        (gnome_volume_control_element_dispose),
        (gnome_volume_control_element_change):
        * gst-mixer/src/element.h:
        * gst-mixer/src/main.c: (main):
        * gst-mixer/src/misc.c:
        * gst-mixer/src/preferences.c:
        * gst-mixer/src/stock.h:
        * gst-mixer/src/track.c: (gnome_volume_control_track_add_title),
        (gnome_volume_control_track_put_switch),
        (gnome_volume_control_track_add_playback),
        (gnome_volume_control_track_add_recording),
        (gnome_volume_control_track_add_switch),
        (gnome_volume_control_track_add_option):
        * gst-mixer/src/track.h:
        * gst-mixer/src/volume.c: (gnome_volume_control_volume_class_init),
        (gnome_volume_control_volume_init), (cb_mouseover), (cb_mouseout),
        (get_button), (gnome_volume_control_volume_new),
        (gnome_volume_control_volume_dispose),
        (gnome_volume_control_volume_size_alloc),
        (gnome_volume_control_volume_expose):
        * gst-mixer/src/volume.h:
        * gst-mixer/src/window.c: (menu_item_select_cb),
        (menu_item_deselect_cb), (connect_proxy_cb), (disconnect_proxy_cb),
        (cb_change), (cb_exit), (cb_preferences_destroy), (cb_preferences),
        (open_uri), (cb_help), (cb_about),
        (gnome_volume_control_window_dispose),
        (gnome_volume_control_window_class_init),
        (gnome_volume_control_window_init),
        (gnome_volume_control_window_new):
        * gst-mixer/src/window.h:
        Use GtkUIManager i.s.o. deprecated libgnomeui
        Remove libgnomeui as a dependency
        Use tango icons if possible and make all icons themeable
        Install deprecated icons from the application itself. Now we just need
        a pixel pusher to make us some nice tango icons for the remaining icons
        Use G_DEFINE_TYPE macro for our own types
        Fixes bug #494031 and bug #310883