GNOME Bugzilla – Bug 304417
Icons, Gtk: Stick to standards
Last modified: 2009-01-29 05:35:40 UTC
Please describe the problem: Evolution should not require pngs for their icons... it should just use normal stock icons as defined in an icon theme... Furthermore: Please use more standard widgets! The Email list is not a gtk list and is basically unthemeable this way... The evo-button for new messages and new appointments and the such is not a standard widget either... therefore the icon on is is kinda small compared to normal buttons. Same with the preferences dialogue, the (non-existant) statusbar etc. Hope you'll do some changes :) Thanx! Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 49407 [details] [review] patch so that SVGs are accepted for stock icons > Evolution should not require pngs for their icons With this simple patch, evolution should accept SVG icons per default. Otherwise you just force everyone to call their SVGs .png.
It's especially annoying that Evolution uses it's own folder icon, when every other gnome program uses the icon from the current theme!
Approved for commit.
adding version number, the new-button issue should be one of {bug 307776, bug 262210, bug 254503 and bug 245342}. i'm going to mark them as dups the next days, yeah.
Andre, are you going to commit this?
shall this also go into 2.4.x?
i've committed the patch to HEAD/2.5.x: http://cvs.gnome.org/viewcvs/evolution/e-util/e-icon-factory.c?r1=1.14&r2=1.15 http://cvs.gnome.org/viewcvs/evolution/e-util/e-gui-utils.c?r1=1.22&r2=1.23 http://cvs.gnome.org/viewcvs/evolution/e-util/ChangeLog?r1=1.583&r2=1.584 benjamin, thanks for your patience. :-)
In my opinion you should call gnome_icon_theme_set_allow_svg() (in the e-gui-utils.c patch) only if you also call gnome_icon_theme_new(). This is only a very small piece, but calling this a second or third (and so forth...) time is just wasting the user's CPU cycles...
*** Bug 325050 has been marked as a duplicate of this bug. ***
sven: small performance issue, reopening. guess you're right...
This is outdated and more or less fixed now. Closing as OBSOLETE.