After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300891 - Now camel should specify the translation domain explicitly to use gettext
Now camel should specify the translation domain explicitly to use gettext
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
1.2.x (obsolete)
Other All
: High normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 308314 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-04-16 19:13 UTC by Changwoo Ryu
Modified: 2005-08-10 03:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
patch to use explicit translation domain (1.89 KB, patch)
2005-04-16 22:06 UTC, Changwoo Ryu 		none Details | Review
revised patch including camel providers (6.70 KB, patch)
2005-04-17 14:54 UTC, Changwoo Ryu 		none Details | Review
revised patch to set each provider's translation_domain (13.65 KB, patch)
2005-04-20 10:27 UTC, Changwoo Ryu 		none Details | Review
updated patch, with some other changes too lazy to remove (23.35 KB, patch)
2005-08-09 05:39 UTC, Not Zed 		committed Details | Review

Description Changwoo Ryu 2005-04-16 19:13:41 UTC 
Please describe the problem:
Camel messages like "Moving messages" or "Filtering messages" are displayed
as-is (not translated) in evolution. It's because camel should find their
messages in "evolution-data-server-1.2" domain, but now it finds in (implicit)
"evolution-1.2" domain.  Now camel uses translation messages in
"evolution-data-server-1.2" domain.  So camel should use gettext in the way like
other libraries:

(1) initialize with bindtextdomain() and bind_textdomain_codeset() in some camel
initialization routines.
(2) use dgettext() instead of gettext()  -- defining
CAMEL_EXPLICIT_TRANSLATION_DOMAIN is enough.


Steps to reproduce:
1. Run evolution in non-English locale
2. Do some mail filtering, moving



Actual results:
Messages like "Moving messages (XX%)", "Filtering Messages (XX%)" are displayed
in English.

Expected results:
They should be translated according to the locale language.

Does this happen every time?
Always.

Other information:
Comment 1 Changwoo Ryu 2005-04-16 22:06:53 UTC 
Created attachment 45336 [details] [review]
patch to use explicit translation domain

It adds initialization code using bindtextdomain() and
bind_textdomain_codeset().  And it defines CAMEL_EXPLICIT_TRANSLATION_DOMAIN
(to use dgettext) and EVOLUTION_LOCALEDIR (for initialization) in Makefile.am
Comment 2 Changwoo Ryu 2005-04-17 14:54:43 UTC 
Created attachment 45356 [details] [review]
revised patch including camel providers

It adds initialization code using bindtextdomain() and
bind_textdomain_codeset().  And it defines CAMEL_EXPLICIT_TRANSLATION_DOMAIN
(to use dgettext) and EVOLUTION_LOCALEDIR (for initialization) in Makefile.am's
Comment 3 Changwoo Ryu 2005-04-20 10:27:51 UTC 
Created attachment 45471 [details] [review]
revised patch to set each provider's translation_domain

It adds initialization code using bindtextdomain() and
bind_textdomain_codeset().  And it defines CAMEL_EXPLICIT_TRANSLATION_DOMAIN
(to use dgettext) and EVOLUTION_LOCALEDIR (for initialization) in
Makefile.am's.	And it sets translation_domain in each provider's CamelProvider
struct.
Comment 4 Not Zed 2005-08-09 05:39:53 UTC 
Created attachment 50437 [details] [review]
updated patch, with some other changes too lazy to remove
Comment 5 Not Zed 2005-08-09 05:40:28 UTC 
committed to 2.4.

thanks for the work, sorry for taking so long to use it.
Comment 6 Not Zed 2005-08-10 03:53:34 UTC 
*** Bug 308314 has been marked as a duplicate of this bug. ***