GNOME Bugzilla – Bug 263207
Advanced Search "Remove" button should be inactive
Last modified: 2009-01-08 16:17:31 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: Advanced Search "Remove" button should be inactive. Steps to reproduce the problem: 1. Start Evolution 2. Search -> Advanced Actual Results: The last remove button in the list should be active, though it does not do anything. Expected Results: The last remove button should get inactive. How often does this happen? Always
please also fix bug 257118 and bug 262950 when working on this one, if possible - it's a bit similar/related. :-)
Hrmm. I think it should remove the item, and disable the OK button maybe. It sucks to have to add something to be able to remove the last rule in the list, even if you are adding a new rule. It is better to be able to move the mouse to one spot, and keep clicking the remove button.
dobey: you're right :-)
*** Bug 304535 has been marked as a duplicate of this bug. ***
changing component to "Mailer" to get rid of the UI component, also reassigning as discussed with nags... adding UI keyword.
Created attachment 68916 [details] [review] bug fixes The last Remove button in Advanced Search is made to be inactive
applied the patch. patch does not work if i add a second condition and remove the second condition again - the "remove" button is not greyed out anymore. so this needs some additional work. a better approach i guess would be to automatically add already one "if" condition when the dialog gets created - currently the user *always* has to *add* a condition.
Created attachment 89806 [details] [review] proposed patch for evolution;
I did it as Rodney suggested in comment #2, so you could remove all rule parts, but then the OK button is disabled.
Milan, the patch works perfectly fine. I see that OK is disabled. I think SAVE should also be disabled. I don't see a reason for SAVE to be enabled when OK is disabled :)
Created attachment 89995 [details] [review] proposed patch for evolution; you have right, this might be better.
btw, as I saw now, when you choose "Date sent", for example, then because of that "validate" calling it claims about not chosen date. Is it good or bad? Maybe it's good, because you could not invoke this message in other way (because OK button is disabled), but it is strange a bit.
It is really BAD. The error says that you have to choose a date, but Im about to do that. May be we need to have an alternate path. Too many things to take care :(
Created attachment 90002 [details] [review] proposed patch for evolution; as you mentioned on IRC, I removed that validate from function which enable/disable OK/Save button and do this only based on a count of rules, so it is working without any error message.
Ill commit this.
Committed to head.
*** Bug 380283 has been marked as a duplicate of this bug. ***