GNOME Bugzilla – Bug 162947
Save confirmation alert diagram (Figure 3.17) shows two buttons with the same access key
Last modified: 2020-12-04 18:19:25 UTC
Figure 3.17. "A save confirmation alert" in the HIG (2.0) has three buttons, but it seems that the keyboard shortcut character for the first two buttons is "C". "Close without Saving", "Cancel", and "Save" ^ ^ ^ http://developer.gnome.org/projects/gup/hig/2.0/windows-alert.html#save-alert-figure
Also note bug 106982 which first mentioned this problem back at the beginning of 2003.
Created attachment 36777 [details] Updated Figure 3.17 with underlined "w"
"Don't Save" with the "n" as the shortcut key seems to be the most common wording for this button [1]. However, if we keep with the recommended wording "Close Without Saving", I suggest we use "w" as the shortcut key, as this is already done in Gedit (2.9.x). Any oposition to changing the "Close without Saving" shortcut key to "W"? I've attached an update of the appropriate image (Figure 3.17). On another note, I can't quite figure out if the "w" in "Close Without Saving" should be upper-case or not. The HIG section on capitalization [2] says that " Command button labels" should use "header" capilalization and that means all initial-caps, except for "Prepositions of three or fewer letters: at, for, by, in, to". So I think "without" should have an upper-case W. Should it? [1] http://actsofvolition.com/include/savealerts/#example [2] http://developer.gnome.org/projects/gup/hig/2.0/design-text-labels.html#layout-capitalization
Looks great. I agree that an upper-case W would make the most sense here (for both issues). If you could attach a new image with that done I'll put it in the draft version of the HIG.
Since bug 106982 got closed in favor of this one, can you also change the word 'past' to 'last' while you're changing the figure?
Yes, sounds good.
Created attachment 36843 [details] Updated save confirmation dialog (Figure 3.17) Here's an updated version of Figure 3.17 with the new "W" shortcut key, the "W" capitalization, and with "past" changed to "last". Patch to follow.
Created attachment 36844 [details] [review] minor fixes for save confirmation figure This patch makes the "W" in "Close Without Saving" upper-case, changes "past x minutes" to "last x minutes", and adds a note to the What's New section. It should accompany the new PNG of Figure 3.17 also posted on this bug.
Ok, looks good. I'll try to get this in soon.
When I proposed the the secondary text "If you *don't save*, your work from the last <time to 0 decimal places> will be lost" (as appears in the HIG), it was intended to precede a button that similarly said "Don't Save" <http://anoncvs.gnome.gr.jp/viewcvs.cgi/guikachu/TODO?rev=1.54>. I agree that "discarded" is better than "lost", but I still think "Don't Save" would be better than "Close Without Saving", on sheer economy of syllables. Whatever the decision, the secondary and button text should be harmonized.
*** Bug 126682 has been marked as a duplicate of this bug. ***
mpt: I think the Primary Text is pretty good right now, so I don't want to change that. Keeping in harmony with the primary text is more important than the secondary text so I'm gonna keep the button the same as well. Any suggestions for the secondary text, I'm pretty swamped on stuff right now so I don't have much time for contemplating it ;-)
The secondary text in the HIG right now ("If you close without saving, changes from the last Time Period will be discarded") matches with the button ("Close without Saving") and seems fine to me. The screenshot would need to be updated, but the actual text is fine.
+1 for the "If you close without saving" change.
So you're going to retain a string that (a) only obliquely addresses the issue (abandoning your changes), (b) is five (!) syllables long, and (c) starts with the same letter as one of the other buttons (making it harder to distinguish), when there are at least two better alternatives available? Oy.
This bug is to get the duplicated access key fixed - let's get that done (with "Close _W_ithout Saving") first. We can open another bug if we want/need to shorted the text on that button.
No idea if you care about my opinion at all, but I vote for changing the secondary text to "If you don't save ..." and the button to "Do_n't Save". This approach is concise, avoids misunderstandings and gets rid of the duplicate mnemonics. The HIG should also make a clear statement on what should be the default button in this dialog. See bug #162872 and bug #162837.
My proposal: * apply _some_ patch * update the image * decide quickly on comment 17 or file a new bug Show must go on :D
We don't include this example any more.