After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161042 - Eeek, why is "Keep Transparency" turned on for Floating Selections?
Eeek, why is "Keep Transparency" turned on for Floating Selections?
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 408261 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-11 20:24 UTC by weskaggs
Modified: 2007-05-27 23:08 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description weskaggs 2004-12-11 20:24:46 UTC
"That's a bad bug that needs to be fixed immidiately." -- Sven

This bug report is a spinoff of bug #151910, because it has higher priority than
that bug.
Comment 1 Kelly Price 2004-12-12 03:36:15 UTC
Bug 151910 actually detected this bug.  I've added the dependency on this bug to
that bug.  To confirm this bug, read that bug's comments for methods to do it.
Comment 2 weskaggs 2004-12-17 19:17:51 UTC
There may be some obscure reason why "Keep Transparency" needs to be turned on
in floating selections, so it might be dangerous to mess with it there.  It
seems likely that it would be safe to turn it off when converting a floating
selection into a layer, though.  Would that be an acceptable fix?
Comment 3 Sven Neumann 2004-12-17 23:25:52 UTC
What about setting it to the state of the layer it was floated from?
Comment 4 Kelly Price 2005-02-21 19:47:30 UTC
Most of the time I'm turning it off, so making it default off but configurable
may be the best way to go.  Some folks may want it to be "always on," "always
off," or "same as layer it was floated from". The last case would be 90% turned
off for me.
Comment 5 weskaggs 2005-06-21 16:56:57 UTC
Well, I have changed HEAD to make it set "Keep Transparency" to FALSE instead of
TRUE when creating a floating selection, and nothing particularly bad seems to
happen.  I'll leave it that way for a while, for testing.

2005-06-21  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimplayer-floating-sel.c: set "Keep Transparency"
	FALSE when creating floating sel; see bug #161042.
Comment 6 Sven Neumann 2005-06-23 23:53:44 UTC
Let's call it fixed then and not attempt to backport it.
Comment 7 Michael Schumacher 2007-02-15 16:06:13 UTC
*** Bug 408261 has been marked as a duplicate of this bug. ***
Comment 8 Michael Natterer 2007-05-27 23:08:03 UTC
Fixed differently now:

2007-05-28  Michael Natterer  <mitch@gimp.org>

	* app/core/gimplayer-floating-sel.c (floating_sel_attach): set
	"Lock Alpha" to TRUE again on floating selections.

	(floating_sel_to_layer): instead, set it to FALSE when turning
	it into a new layer. Fixes bug #418215 and keeps #161042 closed.