GNOME Bugzilla – Bug 152803
HIG violation by the title bar (modification indicator)
Last modified: 2004-12-22 21:47:04 UTC
HIG 2.0 says: "When a document has pending changes, insert an asterisk (*) at the beginning of the window title. For example, *Unsaved Drawing, *AnnualReport." gedit at present has an appended asterisk in the tab title, and a translated "(modified)" appended in the window title.
Created attachment 31609 [details] [review] Patch to make window/tab titles HIG compliant Both the window and tab titles are now ("*%s",docname)
I think that a better fix would be to add a function to gedit_document.c (say gedit_document_get_title_with_attributes, but feel free to come up with a better name) which returns a string with the filename in utf8, the asterisk if needed and [RO] appended if the doc is readonly. Such a func should be used both for the window title and for the tab. see also bug #149553
I don't think it's going to be possible to bring this functionality into one common function, due to the [RO] vs (readonly) issue that we discussed. Having put this to the usability mailing list[1], I think the best way forward is: -For the moment, apply the trivial patch to move the asterisks to the beginning of the filename in window and tab titles -Change the "(readonly)" to "(Read only)" in the window title -Replace the obscure "[RO]" in the tab title with a nautilus-style lock emblem on the document icon in the tab title area, as suggested by Marcus Hammer in [2] 1. http://lists.gnome.org/archives/usability/2004-September/msg00058.html 2. http://kunstradio.at/TEMP/mockupgedit.png
Fixed in CVS HEAD