After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152391 - Nautilus says "Eject" instead of "Unmount" when referring to network folder volume in "Can't Delete Volume" dialog
Nautilus says "Eject" instead of "Unmount" when referring to network folder v...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Trash
0.x.x [obsolete]
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-11 18:33 UTC by Keith Lea
Modified: 2005-03-25 15:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
The proposed patch from bug 154283. (2.85 KB, patch)
2005-01-03 00:26 UTC, Dennis Cranston
needs-work Details | Review

Description Keith Lea 2004-09-11 18:33:06 UTC
When I drag a remote folder (created with "Connect To Server...") to the Trash,
a dialog comes up which says:

You cannot delete a volume icon.
If you want to eject the volume, please use Eject in the right-click menu of the
volume.

However, there is no Eject menu item in the context menu for the icon. Instead,
there is only "Unmount Volume." The dialog's text should be changed.
Comment 1 Dennis Cranston 2004-10-02 07:08:24 UTC
There is a proposed patch in bug 154283 that should resolve this issue.
Comment 2 Matthew Gatto 2004-10-19 20:18:06 UTC
This bug still needs a patch even though the one in bug 154283 was rejected.
Comment 3 Matthew Gatto 2004-10-24 23:11:16 UTC
There is a patch to fix this in bug 152389, comment #6
(http://bugzilla.gnome.org/attachment.cgi?id=32813&action=view).
Comment 4 Dennis Cranston 2005-01-03 00:26:59 UTC
Created attachment 35375 [details] [review]
The proposed patch from bug 154283.
Comment 5 Martin Wehner 2005-03-21 20:55:00 UTC
Comment on attachment 35375 [details] [review]
The proposed patch from bug 154283.

The patch leaks a volume ref and the link display name. Perhaps using an
eject_for_type() function like in the directory and tree view would make it a
bit more readable.
Thanks & Sorry for the long delay.
Comment 6 Martin Wehner 2005-03-25 15:16:00 UTC
2005-03-25  Martin Wehner  <martin.wehner@gmail.com>

	* libnautilus-private/nautilus-desktop-link-monitor.c:
	(eject_for_type), (volume_delete_dialog),
	(nautilus_desktop_link_monitor_delete_link):
	Reference the proper context menu item in the volume
	delete dialog of network volumes. Fixes bug #152391.
	
	Patch from Dennis Cranston <dennis_cranston@yahoo.com>