After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 150107 - Glade should use "translator-credits" intead of "translator_credits"
Glade should use "translator-credits" intead of "translator_credits"
Status: RESOLVED WONTFIX
Product: glade-legacy
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Damon Chaplin
Damon Chaplin
: 150108 (view as bug list)
Depends on:
Blocks: 150106
 
 
Reported: 2004-08-14 09:00 UTC by Christian Rose
Modified: 2005-07-24 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Rose 2004-08-14 09:00:52 UTC
Glade should a hyphen instead of an underscore in the special translator
credits string, i.e "translator-credits" instead of "translator_credits".

The reason is that some translation tools check that messages which have access
keys in the source also have access keys in the translation, and barf otherwise.

Obviously those tools will mistake this underscore for an access key. Please see
bug 150106 for further details.
Comment 1 Damon Chaplin 2004-09-23 14:08:23 UTC
I'm happy to do this, but it means we may lose all the old translations.
Is that OK?
Comment 2 Damon Chaplin 2004-09-23 14:43:50 UTC
It also needs a change in libgnomeui, in libgnomeui/glade/glade-gnome.c.

about_set_translator_credits() has this:
   if (strcmp(value, "translator_credits") != 0) {

We'd need to change that to check for "translator-credits" as well.

To be honest, I think it is too late/too much hassle to change this now.
Translator tools should be fixed so that you can override the access keys check.
Comment 3 Christian Rose 2004-09-23 14:55:07 UTC
Danilo, Chris, Kjartan, what do you think?
Comment 4 Damon Chaplin 2004-11-27 14:56:40 UTC
*** Bug 150108 has been marked as a duplicate of this bug. ***
Comment 5 Damon Chaplin 2004-12-07 14:01:24 UTC
Glade uses "translator-credits" for the new GtkAboutDialog.
GnomeAbout is deprecated now, so I think we shouldn't worry about it.
Comment 6 Christian Neumair 2005-01-07 12:20:18 UTC
Damon: Why don't we simply fix it? It's heavily trivial and users who use old
software will complain.
Comment 7 Damon Chaplin 2005-01-07 14:48:38 UTC
It would need to be fixed in libgnomeui first, and there are several disadvantages
(see above).

I would have thought it would be equally trivial to change the validation tools
so they ignore "translator_credits".
Comment 8 Damon Chaplin 2005-07-24 16:57:20 UTC
There is no reason to use GnomeAbout any more, so this isn't worth fixing.