GNOME Bugzilla – Bug 145331
can't unselect entry in nautilus list view (singleclick mode)
Last modified: 2005-07-29 20:30:31 UTC
Description of Problem: When using nautilus list view, it's not possible to unselect an entry with CTRL+"Left Mouse Button" which has formerly been selected with CTRL+"Left Mouse Button". You have to use CTRL+R to get the (all) entries deselected. This only happens when nautilus is in list view mode. You have to select single click selection mode to reproduce this. Steps to reproduce the problem: 1. Select list view in nautilus 2. Select an entry with "CTRL+Mouse" 3. Now try to unselect with "CTRL+Mouse" Actual Results: Entry doesn't get unselected. Expected Results: Entry should get unselected How often does this happen? always Additional Information: Nautilus 2.6.1
*** Bug 147252 has been marked as a duplicate of this bug. ***
*** Bug 150943 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of 131226 ***
This is actually not a dup of bug 131226 (see bug 147252). Re-opening.
This works for me in 2.8.x. Closing as fixed. Please reopen if it's still a problem with 2.8.x or newer releases.
Bug has _not_ been fixed in gnome gnome-2.8.1-r1. It is not possible to _deselect_ files in _singleclick_ mode _listviews_. If you test this, please make sure it's exactly this mode as others do work (i.e. deselecting singleclick iconview works).
Thanks for setting me straight, tested on 2.9.x and it's very much still there. Luis, probably not a blocker for 2.10.0, but still annoying for people using single click mode.
Created attachment 47409 [details] [review] CTRL + single click deselect fix This is one of the most annoying bugs I have found, as alot of people use the single click mode with list view. Here is a patch that fixes it, once and for all! After review, this should definitely get put into cvs in time for 2.12.
Created attachment 47418 [details] [review] Fix deselect when ctrl+click version 2 Updated patch, fixed unselect logic
Created attachment 47560 [details] [review] CTRL + single click deselect fix + double click fix New patch with updated fixes, includes fix for ignoring double click when in single click policy.
Created attachment 47975 [details] [review] ctrl+single click patch version 3 ok, this one should really fix it...
That is not right. Ctrl-alt should unselect on release, so that dragging works with ctrl. I'm commiting this fix: diff -u -p -r1.249 fm-list-view.c --- src/file-manager/fm-list-view.c 17 Jun 2005 14:15:04 -0000 1.249 +++ src/file-manager/fm-list-view.c 20 Jun 2005 10:11:36 -0000 @@ -257,8 +257,7 @@ fm_list_view_did_not_drag (FMListView *v if ((event->button == 1 || event->button == 2) && ((event->state & GDK_CONTROL_MASK) != 0 || (event->state & GDK_SHIFT_MASK) == 0) - && view->details->row_selected_on_button_down - && (click_policy_auto_value == NAUTILUS_CLICK_POLICY_DOUBLE)) { + && view->details->row_selected_on_button_down) { if (!button_event_modifies_selection (event)) { gtk_tree_selection_unselect_all (selection); gtk_tree_selection_select_path (selection, path);
*** Bug 311840 has been marked as a duplicate of this bug. ***