After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144913 - Make the Gimpressionist Automatable
Make the Gimpressionist Automatable
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 144922 145191
 
 
Reported: 2004-06-24 13:27 UTC by Shlomi Fish
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A Patch to Implement the Functionality. (5.23 KB, patch)
2004-06-24 13:29 UTC, Shlomi Fish
none Details | Review
An updated Patch (6.26 KB, patch)
2004-06-25 15:03 UTC, Shlomi Fish
none Details | Review
An updated Patch, that fixes a bug. (6.29 KB, patch)
2004-06-27 13:21 UTC, Shlomi Fish
none Details | Review

Description Shlomi Fish 2004-06-24 13:27:22 UTC
The Gimpressionist PDB function is at the moment completely useless for 
automatic scripts. It can only run interactively, and does not accept a preset 
argument. It needs to be made automatable, and a patch that will be attached 
here will make it just that.
Comment 1 Shlomi Fish 2004-06-24 13:29:07 UTC
Created attachment 28982 [details] [review]
A Patch to Implement the Functionality.

This is a patch that implements the desired functionality. It's not very
complex, and it was a relatively straightforward change.
Comment 2 Shlomi Fish 2004-06-25 15:03:01 UTC
Created attachment 29005 [details] [review]
An updated Patch

This is an updated patch to this issue. It also corrects the Ballpark theme bug
reported in bug 144922.
Comment 3 Shlomi Fish 2004-06-27 13:21:44 UTC
Created attachment 29040 [details] [review]
An updated Patch, that fixes a bug.

This patch fixes a (possible) bug in the previous version of the patch that was
spotted after reviewing the patch contents themselves. A common pattern was
encapsulated as a function, which was not added to one of the lines 
there.
Comment 4 Michael Natterer 2004-07-02 13:32:04 UTC
Fixed in CVS:

2004-07-02  Michael Natterer  <mitch@gimp.org>

	* plug-ins/gimpressionist/Makefile.am
	* plug-ins/gimpressionist/*.[ch]: applied patch from Shlomi Fish
	that massively cleans up gimppressionist (touching all files and
	addding some new ones) and adds a simple PDB interface for
	selecting one of the previously created presets.
	Fixes bugs #145191, #144913 and #144922.