GNOME Bugzilla – Bug 135710
wnck window menu out of sync with metacity
Last modified: 2006-01-21 19:53:31 UTC
I was actually surprised to discover that metacity was not generating the wnck tasklist menu. We should really use some sort of protocol to get metacity to do this rather than libwnck. At any rate in metacity the window menu no longer has "Roll Up/Unroll" (it's replaced by an On Top check menu item). At the very least we should remove the shade window menu options to sync the UI better. Attached patch simply #if 0s the appropriate code sections to remove the shade from the menu.
Created attachment 24911 [details] [review] resync
*** Bug 143510 has been marked as a duplicate of this bug. ***
See also bug 96087 (which is actually about two bugs).
*** Bug 143946 has been marked as a duplicate of this bug. ***
Created attachment 37339 [details] [review] Really resync menus.
Created attachment 37340 [details] [review] Really resync menus. Attempt 2. This time with properly working mnemonic. 1. This neither fixes the protocol issue nor does it fix lack of workspace action sync 2. This definitly has to be approved. We're string and UI frozen.
Thanks for tackling this. This patch overall looks good, but some nitpicks: - Please use -p when submitting patches - Please match the surrounding code style (replace tabs with spaces and only use one space between function name and its arguments in a .c file) - The special casing of ABOVE in make_menu_item is inconsistent with the rest of the code - You have a spurious change on an empty line Also, while the patch is definitely nice, I don't think it's worth breaking string or UI freeze for this (not many people know about or use the right click menu). Maybe Mark or Vincent or Havoc disagrees, but I see no harm in waiting until after 2.10...
Created attachment 37376 [details] [review] Attempt 3.
Seems fine to me for accepted-commit_after_freeze. Vincent, Mark, or Havoc: Could one of you comment?
Comment on attachment 37376 [details] [review] Attempt 3. I think Elijah is right. I too think that not a lot of people use the context menu on the window list. Thanks for the patch!
Comment on attachment 37376 [details] [review] Attempt 3. I'm sure Vincent meant accepted-commit_after_freeze and not accepted-commit_now...
Indeed. Thanks Elijah for watching me ;-)
The patch has a trivial conflict now but otherwise is still fine. Christian: it's long after freeze. Would you like to commit this now and notify gnome-doc-list and gnome-i18n-list or should I?
Ooops, forgot to do it; we'll have to wait until next thaw.
Created attachment 51715 [details] [review] Proposed Patch Recreated patches given by leena (in bug #96087) and Christian's patch with some modifications.
*** Bug 319789 has been marked as a duplicate of this bug. ***
Is there no technical way to get wnck to simply invoke the metacity menu without cloning it? Or vice-versa. I consider myself a GNOME power-user and I don't think I've clicked any of the window control buttons for months. Alt-right-click is a lot quicker. And if you want to close a lot of windows, right clicking window list items is quicker than the activate, find X, click X cycle. My 2p.
I couldn't think of a way to have wnck invoke the metacity menu, no. Maybe someone else can. It's easier to just sync them (it's not like they should be changing often)
I am just thinking that if an application wants to add custom window context menu items like in Windows, the synchronisation would break. There probably isn't currently a way to do that, though?
IMHO the onliest way of achieving synchronized window menus is that we a) expose the information using IPC, which allows for activation of custom actions (are they planned at all?) b) use a shared library providing the menu items. However, this still needs sync since it requires that both have an idea of what rolling up a window is c) continue to sync them, as the patch from Srirama does I'm marking my patch as obsolete, since Srirama's patch consolidates more synchronization work into one patch. Elijah: Any chance that you could review the patch? :)
*** Bug 327853 has been marked as a duplicate of this bug. ***
*** Bug 327969 has been marked as a duplicate of this bug. ***
Sorry for the incredibly long wait; I committed it finally. Thanks Leena, Christian, and Srirama!