GNOME Bugzilla – Bug 135704
Allow to include some gdk-pixbuf-loaders even with -DUSE_GMODULE
Last modified: 2010-07-10 04:04:22 UTC
To get a more robust Gtk+ build I use to include the minimum required moules with-in the respective library. This is simple with Pango (just link in pango/modules/modules/basic-$(PLATFORM).c); the optional rest is build as modules. This way the user gets - even with a broken setup - the ability to read error meesages. For gtk the pixbuf loaders XPM and PNG are similar important, (IIRC crashing sooner or later without them) so I'd like to include them as well. Though possible with the current code it also requires to include _all_ wanted loaders, cause one has to undefine USE_GMODULE. [Would be ok for loaders included in Gtk+, but dissallows to use external loaders like the librsvg one.] The following patch does make USE_GMODULE independent of INCLUDE_$(format). It reflects the current needs outlined above, i.e. not all io-$(format).c are changed yet, but you get the idea ;-) Does this patch have any chance to be accepted ? Thanks, Hans
Created attachment 24904 [details] [review] The (incomplete) patch mentioned above
So, the proposal is to make --with-included-loaders specify a set of static loaders to include and the rest get built dynamically? I'm not opposed to a clean implementation of that for 2.6. See bug 71414 for a related bug with making it possible to chose both the set of statically included loaders and the set of dynamical loaders built for Pango. Removing the PATCH keyword, since that generally is supposed to refer to a patch that is potentially ready to apply.
*** This bug has been marked as a duplicate of 354184 ***