After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 126722 - gok should read locale-specific .kbd files when available
gok should read locale-specific .kbd files when available
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
AP3
Depends on:
Blocks: 122112
 
 
Reported: 2003-11-11 13:20 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
i'll commit this patch tomorrow if there is no complaint (1.79 KB, patch)
2003-11-19 00:11 UTC, David Bolter
none Details | Review

Description bill.haneman 2003-11-11 13:20:12 UTC
Now that bug 46650 is nearly fixed, gok should attempt to read a
locale-specific keyboard file when one is available.

This means that the *.kbd files read in gok_main_read_keyboard_from_dir
should attempt to open files in <dir>/<locale>/*.kbd instead of just
<dir>/*.kbd.  If such a directory doesn't exist, then GOK should fall back
to appropriate near-matches or at worst, <dir>/*.kbd (for C locale).

I believe there is code in libgnome for getting a 'list' of locale strings
matching the current LC_MESSAGES locale, in order of best-to-worst match. 
I believe this list includes the C locale but I'm not sure.

David, can you take this one?  I can help point you to the libgnome APIs if
you get stuck, but perhaps you can do the investigation from there.

At the moment (while gok_main_read_keyboards_from_dir doesn't search
subdirectories) you can test GOK's internationalized keyboard by specifying
a locale subdir in gconf.  However doing this requires applying the latest
version of the patch to bug 46650 from bugzilla which isn't in CVS as of
13:00 GMT 11/11/03.
Comment 1 David Bolter 2003-11-19 00:11:29 UTC
Created attachment 21602 [details] [review]
i'll commit this patch tomorrow if there is no complaint
Comment 2 David Bolter 2003-11-19 13:35:47 UTC
fixed in head