After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125175 - Please use ngettext in gnome-control-center
Please use ngettext in gnome-control-center
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other other
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 116236
 
 
Reported: 2003-10-22 04:13 UTC by Danilo Segan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. I've found one more string. (2.75 KB, patch)
2003-12-30 19:25 UTC, Christian Neumair
none Details | Review

Description Danilo Segan 2003-10-22 04:13:35 UTC
From bug 116236:
As mentioned in
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals,
the common way of handling plurals is broken for many locales. A way to
solve this is by using ngettext instead, as mentioned in that document.

A simple code example of code using ngettext:

  g_printf (ngettext ("Found %d file.", "Found %d files.",
nbr_of_files),nbr_of_files);

We should make all of GNOME use this when needed.


Relevant strings:
#: capplets/font/main.c:495
#, c-format
msgid ""
"The font selected is %d points large, and may make it difficult to "
"effectively use the computer.  It is recommended that you select a size "
"smaller than %d."

#: capplets/font/main.c:500
#, c-format
msgid ""
"The font selected is %d points large, and may make it difficult to "
"effectively use the computer.  It is recommended that you select a smaller "
"sized font."

Both of these should be pluralized on "%d points".

Bug 124064 (providing ngettext check for control-center) is related to this
issue.
Comment 1 Christian Neumair 2003-12-30 19:25:38 UTC
Created attachment 22778 [details] [review]
Proposed patch. I've found one more string.
Comment 2 Jody Goldberg 2003-12-30 19:36:13 UTC
The framework seems to be in place and we've jsut released which will
give us time to catch any build issues.  Please commit all of these.
Comment 3 Christian Neumair 2003-12-30 19:53:04 UTC
Committed. Closing.

regs,
 Chris