After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117923 - Have buttons for increase/decrease size instead of percentage menu
Have buttons for increase/decrease size instead of percentage menu
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
1.9.x
Other Linux
: Normal enhancement
: 2.14.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 124101 142259 (view as bug list)
Depends on:
Blocks: 301969
 
 
Reported: 2003-07-20 19:53 UTC by Reinout van Schouwen
Modified: 2006-01-12 22:08 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
put zoom in/out buttons in toolbar editor (613 bytes, patch)
2003-08-03 13:55 UTC, Christian Persch
none Details | Review
this adds two buttons for Zoomin & Zoomout (1.16 KB, patch)
2005-02-03 07:04 UTC, Sudhakar Naidu.A
none Details | Review

Description Reinout van Schouwen 2003-07-20 19:53:32 UTC
The toolbar widget for changing font size uses percentages that don't
really mean anything. '100%' can mean something when you're editing
documents for printing, then it would mean 'exactly this size on paper'.
But Epiphany is for viewing online documents.

My suggestion is to replace the percentage widget by buttons for size
increase/decrease, analogous to the corresponding items in the View menu.
Comment 1 Christian Persch 2003-07-20 20:09:57 UTC
Being able to put zoom in/zoom out buttons on the toolbar is just a
matter of adding the verbs 'ViewZoomIn' and 'ViewZoomOut' in
data/ui/epiphany-toolbar.xml.in .

But the zoom control toolbar item is useful, because it allows you to
go immediately to the desired zoom level. This may not matter when you
only want to zoom one step, but because zooming is very very slow, it
really matters as soon as you want a difference of 2 or more steps.

Back when i improved the zoom capabilities, i originally had added
those buttons to the available toolbar repertoire, but (iirc) daveb
thought the zoom control alone was enough, and that's what i think too.
Comment 2 Dave Bordoley [Not Reading Bug Mail] 2003-07-20 21:29:40 UTC
I really prefer the existing design, but we can consider ways to make
it better if needed post 1.0 so lets leave this open for now and we
can have some more discussion.
Comment 3 Marco Pesenti Gritti 2003-08-03 00:57:51 UTC
Some points in favor of a two buttons design.

http://www.useit.com/alertbox/20020819.html

I wonder if we should just use new nautilus design.
Comment 4 Dave Bordoley [Not Reading Bug Mail] 2003-08-03 13:30:16 UTC
I'm more incline to make the zoom in and zoomout toolbar buttons than
use the nautilus design, i just don't like it for some reason.
hmmm.... the comment about making it a default button is interesting
though....
Comment 5 Christian Persch 2003-08-03 13:55:19 UTC
Created attachment 18873 [details] [review]
put zoom in/out buttons in toolbar editor
Comment 6 Christian Persch 2003-08-03 13:57:58 UTC
So for anyone who want to try if zoom in/out buttons make sense, apply
the above patch, and then you can use the toolbar editor to add them
to you toolbar.

However i still think the current zoom control is sufficient.

About the nautilus zoom control: it certainly would be possible to
port it to epiphany with _no_ changes except to ephy-zoom-control.c.
Comment 7 Marco Pesenti Gritti 2003-08-03 14:29:51 UTC
I dont think we should have both (buttons and control). I sort of feel
that the list require some more thinking then two buttons and I dont
like that. I guess this is all post 1.0 anyway. I pasted the link
because I found it accidentally.
Comment 8 Marco Pesenti Gritti 2003-09-01 13:22:37 UTC
Sorry for the spam. Reassigning bugs with a target to our next milestone.
Comment 9 Christian Persch 2003-10-08 06:36:15 UTC
*** Bug 124101 has been marked as a duplicate of this bug. ***
Comment 10 Christian Persch 2003-10-08 06:37:49 UTC
The dup'd bug 124101 advocated to port the nautilus zoom control.
Comment 11 spark 2004-02-07 22:46:29 UTC
Target 1.2 -> 1.4 due to feature freeze.
Comment 12 Christian Persch 2004-04-08 22:03:56 UTC
Comment on attachment 18873 [details] [review]
put zoom in/out buttons in toolbar editor

Marking obsolete attachments in open bugs.
Comment 13 Christian Persch 2004-05-10 10:45:39 UTC
*** Bug 142259 has been marked as a duplicate of this bug. ***
Comment 14 Christian Persch 2004-07-25 13:26:19 UTC
Mass-moving Target 1.4 -> 1.6 because of feature and UI freeze. Sorry for the
bugspam, search for "mass-move-1.4-1.6" to filter all of it.
Comment 15 Christian Persch 2004-07-25 13:31:28 UTC
Mass-moving Target 1.4 -> 1.6 because of feature and UI freeze. Sorry for the
bugspam, search for "mass-move-1.4-1.6" to filter all of it.
Comment 16 Christian Persch 2004-10-13 10:54:56 UTC
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 17 Josh Lee 2004-10-16 22:08:58 UTC
If you change the zoom control, make sure it still responds to the mouse wheel.
I find it very convenient to move my mouse to up the zoom control and scroll to
the desired size.
Comment 18 Sudhakar Naidu.A 2005-02-03 07:04:52 UTC
Created attachment 36905 [details] [review]
this adds two buttons for Zoomin & Zoomout
Comment 19 Christian Persch 2005-02-10 18:23:54 UTC
Mass-moving bugs from Target Milestone: 1.6 to 1.8 because of feature, UI and
string freeze.
Comment 20 Christian Persch 2005-07-03 15:33:04 UTC
How about using the nautilus design (but only if evince did the same), as
suggested in comment 3 and comment 4 ?
Comment 21 Reinout van Schouwen 2005-07-03 16:27:08 UTC
In evince, you can already put the zoom controls on the toolbar like this: 

 (+) [100%<>] (-) 

I'm not sure how desirable it is to force these items into one widget like
nautilus does. Evince has to support the special 'Page width' and 'Best fit'
sizes; I don't know how this would work with the nautilus control. Also, like I
said in the original report, percentages don't have the same meaning for web
documents that they have for print documents.

How does Sudhakar's patch do it?
Comment 22 Christian Persch 2005-07-30 21:17:31 UTC
Target: 1.8 -> 1.10 due to feature and UI freeze.
Comment 23 Reinout van Schouwen 2005-11-30 12:03:27 UTC
See also http://mail.gnome.org/archives/usability/2005-October/msg00157.html
Comment 24 Reinout van Schouwen 2006-01-10 15:18:03 UTC
Updating fields
Comment 25 Christian Persch 2006-01-12 22:08:56 UTC
Fixed in cvs.