After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112474 - no keynav for notification area
no keynav for notification area
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-CD
2.5.x
Other All
: High major
: ---
Assigned To: gnome media maintainers
gnome media maintainers
AP2
: 108327 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-05-07 09:49 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (4.21 KB, patch)
2004-02-11 17:22 UTC, padraig.obriain
none Details | Review

Description bill.haneman 2003-05-07 09:49:50 UTC
DrWright doesn't seem to allow posting of it's context (aka right-click)
menu when in the notification area on the panel.

Or is this a notification area bug ?
Comment 1 Richard Hult 2003-05-26 10:00:20 UTC
It looks like the icons don't get focus, only the applet itself. I'll
leave this open until I've investigated a bit further.
Comment 2 Calum Benson 2003-06-25 23:42:19 UTC
Marking AP2 to reflect a11y team's assessment of a11y impact.  Would
be AP1 if we were actually shipping anything anytime soon that used
the notification area properly, but I don't think we are :)
Comment 3 Calum Benson 2003-07-02 18:17:47 UTC
*** Bug 108327 has been marked as a duplicate of this bug. ***
Comment 4 Calum Benson 2003-08-07 16:07:45 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 5 Matt Keenan (IRC:MattMan) 2004-01-21 17:24:14 UTC
Just tried this one out and some of the problems mentioned in bug 108327
are resolved :

   Applet has focus, Ctrl-F10 for panel menu  :  works
                     Ctrl-F1 for toolbar      :  not working
                     Hover mouse for toolbar  :  works

Using mouse you can get individual context menus for the icons that
are contained in the navigation applet, however as the individual
icons do not get focus, the context menus are not accessable via 
keyboard navigation.
Comment 6 Mark McLoughlin 2004-02-04 10:03:42 UTC
Re-assigning to gnome-panel-maint. Apologies for the spam.
Comment 7 padraig.obriain 2004-02-09 11:48:12 UTC
The first problem I see is that focus does not go the notification
area if an icon is present. If the notification area is empty then
focus does go there. Strange. I will try to figure out what is
happening.
Comment 8 padraig.obriain 2004-02-09 16:04:36 UTC
The problem is not so much with the notification area applet as with
the applications which put somthing in it.

The notification area consists of a GtkPlug (PanelApplet) which may
contain one or more GtkSockets. The GtkPlug corresponding to the
GtkSocket, in the case of of gnome-cd, consists of an EggTrayIcon,
which contains a GtkImage inside a GtkEventBox. The tooltip is defined
on an EggTrayIcon. None of these objects receive focus which explains
the behavior is described in my previous comment.

A child of the EggTrayIcon, either the GtkEventBox or the GtkImage
needs to be focusable and a focus indicator drawn around it. Also the
context menu needs to be popped up when the Shift+F10 is pressed.
Comment 9 Calum Benson 2004-02-10 15:53:41 UTC
A focused notification area icon should just look the same as a
focused panel launcher icon: dotted box around it (width specificed by
theme) extending to or near the edge of the panel.  I've no idea
whether it should be the image or the event box that's focused, as
long as it looks and behaves right :)  If it's all the same, perhaps
it should be the event box so that things other than images (e.g. a
text label) can be swapped in later if need be, or would that not make
any difference anyway?

Another couple of random keynav notes:

- focus should go the gripper bar before it gets to the icons (much
like it does with the window list applet), so you can pop up the
applet's context menu as well as each icon's context menu;

- pressing Space or Enter when an icon is focused should perform that
icon's default action, i.e. same as clicking it (is the applet
responsible for this, or is it the application providing the icon?)
Comment 10 Gregory Merchan 2004-02-11 02:47:45 UTC
With the current protocol, the icon is responsible for drawing focus
indication and other responses to keyboard and mouse events. This
can be changed, but must be done at the protocol level.
Comment 11 padraig.obriain 2004-02-11 17:20:41 UTC
This will have to be fixed in every application that uses the
notification area. I have a patch for gnome-cd. I am therfore
transferring this bug to gnome-media
Comment 12 padraig.obriain 2004-02-11 17:22:43 UTC
Created attachment 24315 [details] [review]
Proposed patch
Comment 13 Vincent Untz 2004-02-11 17:32:45 UTC
Padraig: is it possible to fix this inside eggtrayicon.c? Because it
would allow us to easily fix this in every application...
Note that I haven't looked at the code and I don't know what's
involved here. It's just a thought.
Comment 14 padraig.obriain 2004-02-16 15:32:12 UTC
I agree that it would be much better if it could be done in
eggtrayicon.c but I do not think that that is possible. Perhaps Anders
could suggest how.
Comment 15 Ted Gould 2004-02-19 06:34:30 UTC
Patch is submitted to HEAD.  Thank you very much for the patch!